Commit Graph

2905 Commits

Author SHA1 Message Date
Roger Light
80a4063bb4
Merge pull request #2683 from guillaumepellegrino/fixes_memleak
Fix memory leak in mosquitto_tls_opts_set()
2022-12-07 22:41:29 +00:00
Roger Light
ed5a39dd93
Merge pull request #2690 from ronybc/patch-1
Removed repeated line
2022-12-07 22:08:14 +00:00
Roger Light
55e448e38d
Merge pull request #2699 from rswindell/include_inttypes
Fix build error: expected ‘)’ before ‘PRIu64’
2022-12-07 22:06:31 +00:00
Roger A. Light
06d5835270 Add more WITH_BROKER guards. 2022-12-03 22:59:14 +00:00
Rob Swindell
7ff744d60d Fix build error: expected ‘)’ before ‘PRIu64’
system with 'make WITH_TLS=no WITH_CJSON=no WITH_DOCS=no'

Signed-off-by: Rob Swindell <rob@synchro.net>
2022-12-02 11:52:34 -08:00
Roger A. Light
8285a57bb9 Fix some error handling related to the bind_interface option. 2022-12-02 14:31:40 +00:00
Roger A. Light
c06599fab2 Fix some retained topic memory not being cleared immediately after used. 2022-11-29 11:55:55 +00:00
Rony B Chandran
d1cdaec963
Removed repeated line
<listitem><para><option>%I</option> ISO-8601 format date and time, e.g. 2016-08-10T09:47:38+0100</para></listitem>
2022-11-22 11:53:31 +05:30
Guillaume PELLEGRINO
9018f12dfc Fix memory leak in mosquitto_tls_opts_set()
When calling mosquitto_tls_opts_set() multiple time in a row
on the same mosquitto context (Example: trying to reconnect
to mqtt broker), some of the tls options are not free, resulting in a memory leak.

The TLS options (tls_version, tls_ciphers) must be free before being set.

Signed-off-by: Guillaume PELLEGRINO <guillaume.pellegrino@yahoo.com>
2022-11-09 10:17:03 +01:00
Roger Light
7ff2198c7d
Merge pull request #2648 from impulsdampf22/fixes
Fixed empty string crash in mosquitto_property_copy_all
2022-11-03 18:43:13 +00:00
Roger A. Light
0cee0d1d11 Fix Coverity Scan 1486944 (backport from develop) 2022-10-26 10:06:38 +01:00
Roger Light
db114fa1d3
Merge pull request #2614 from HashimJVZ/patch-1
Correct a wrong example
2022-10-10 11:26:01 +01:00
Roger Light
d4e69c41bf
Merge pull request #2621 from CastleOnTheHill/master
Fix comments errors, it is the client that sends PING to broker actively
2022-10-10 11:15:29 +01:00
Alexander Fiebig
28416da47a Fixed empty string crash in mosquitto_property_copy_all
Signed-off-by: Alexander Fiebig <alex.fiebig@online.de>
2022-10-08 19:08:21 +02:00
Roger A. Light
5c3c5d779f Fix Coverity 1486949 2022-08-31 11:36:53 +01:00
Roger A. Light
f44d8fad50 Fix Coverity 1491742 and 1491741 2022-08-31 10:00:05 +01:00
Roger A. Light
e22030bb2c Try to convince Coverity this string is terminated. 2022-08-31 09:49:37 +01:00
Arvin
dcad2e410a Fix comments errors, it is the client that sends PING to broker actively 2022-08-24 23:28:06 +08:00
Roger A. Light
86fffa34a9 Fix $SYS messages being expired after 60 seconds
and hence unchanged values disappearing. Thanks to Wim Nelis and
Christoph Krey.
2022-08-22 15:57:14 +01:00
Roger A. Light
ef44b22cef Fix local bridge session expiry interval. 2022-08-18 15:06:11 +01:00
Roger A. Light
1af3152ddc Fix persisted clients being restored without a session expiry time. 2022-08-18 14:13:35 +01:00
Roger A. Light
a8448a9c7b Revert 1.x docker builds to alpine 3.14 due to openssl build errors 2022-08-16 16:05:08 +01:00
Roger A. Light
e9b2fddaa5 Update security page 2022-08-16 16:00:12 +01:00
Roger A. Light
7898f12825 Update docker 2022-08-16 15:07:54 +01:00
Roger A. Light
b0277869d9 Update changelog for last minute fix 2022-08-16 14:32:59 +01:00
Roger A. Light
004b45fa40 Merge branch 'hardillb-x-forwarded-for-lws' 2022-08-16 14:30:42 +01:00
Roger A. Light
4a6570567a Merge branch 'x-forwarded-for-lws' of https://github.com/hardillb/mosquitto into hardillb-x-forwarded-for-lws 2022-08-16 14:30:37 +01:00
Ben Hardill
0eec37af99
Add support for X-Forwarded-For LWS
I know you've added this for the next release, but here is a fix
for LWS. But just incase there are any more 2.0.x releases.

It does leave the incoming port as 0 but as this is pretty meaningless
for a proxied connection I think it's probably ok.

Signed-off-by: Ben Hardill <hardillb@gmail.com>
2022-08-16 13:54:06 +01:00
Roger A. Light
9d9469cbec Merge branch 'fixes' 2022-08-16 13:13:06 +01:00
Roger A. Light
966601f6b6 Bump version, new web post 2022-08-16 13:03:44 +01:00
Roger A. Light
4d1b587e29 dynsec: Forbid deleting the anon group. 2022-08-16 12:55:48 +01:00
Roger A. Light
7917553eb2 Fix expired messages causing queued messages not to be delivered.
Closes #2609. Thanks to JSchy65.
2022-08-16 12:29:18 +01:00
Roger A. Light
cd88906132 Clearer function name 2022-08-16 12:28:13 +01:00
Roger A. Light
df317ff71f Dynamic security: Fix the plugin being able to be loaded twice.
Currently only a single plugin can interact with a unique $CONTROL
topic. Using multiple instances of the plugin would produce duplicate
entries in the config file.

Closes #2601.
Closes #2470.
2022-08-16 01:27:55 +01:00
Roger A. Light
436f0b9348 dynsec: Fix modifyClient and modifyGroup commands
They will now not modify the client/group if a new group/client being
added is not valid, or on other failures.

Closes #2598. Thanks to Sebastian Szczepański.
2022-08-16 00:48:02 +01:00
Roger A. Light
b22df5140e Clear errno before check. 2022-08-16 00:23:06 +01:00
Roger A. Light
49ebb58569 Fix failure to close thread in some situations.
Closes #2545. Thanks to p-luke.
2022-08-15 22:17:00 +01:00
Roger A. Light
fa31b6f41d Fix bridge queued messages not being persisted.
This happens when local_cleansession is set to false and cleansession is
set to true.

Closes #2604. Thank to Frank Dekervel.
2022-08-13 22:46:19 +01:00
Roger A. Light
1ed0c0436a Run lock only once per week 2022-08-13 21:39:25 +01:00
Muhammed Hashim
b3e26c21d7
Correct a wrong example
mosquitto_ctrl example for setClientId was provided with wrong example (duplicate of setClientPassword).
2022-08-13 11:24:59 +05:30
Roger A. Light
5d18962486 Improve custom SSL_CTX tests.
Issue #2463.
2022-08-12 08:52:40 +01:00
Roger A. Light
80c7726d5c Fix confusing error message when dynamic security config file was a directory.
Closes #2520. Thanks to sezanzeb
2022-08-12 08:34:56 +01:00
Roger A. Light
775bd2effd Fix confusing "out of memory" error.
This happens when a client is kicked in the dynamic security plugin.

Closes #2525. Thanks to sezanzeb.
2022-08-12 08:17:17 +01:00
Roger A. Light
268a2bae47 Update lock-threads workflow 2022-08-11 15:32:52 +01:00
Roger A. Light
c4664f08ac Clarify use_username_as_clientid is not global 2022-08-11 11:51:53 +01:00
Roger A. Light
02b92b97ef Fix use of MOSQ_OPT_SSL_CTX when used with MOSQ_OPT_SSL_CTX_DEFAULTS
Closes #2463. Thanks to Tim Nordell.
2022-08-10 17:18:33 +01:00
Roger A. Light
f9fa19ce6a - Fix -o not working in mosquitto_ctrl, and typo in related documentation.
Closes #2471. Thanks to Vitaljok and rillbert
2022-08-10 15:14:32 +01:00
Roger A. Light
6468bb4f9b Fix documentation omission around mosquitto_reinitialise.
Closes #2489. Thanks to rroguski
2022-08-10 14:31:34 +01:00
Roger A. Light
351911bd8f Fix incorrect return code being sent in DISCONNECT.
This is for when a client session is taken over.

Closes #2607. Thanks to der-b
2022-08-10 14:17:22 +01:00
Roger A. Light
08610f7c99 Further fix for #2546. 2022-08-09 21:25:55 +01:00