Roger A. Light
618cd7006b
Don't try to start DLT logging if DLT unavailable.
...
This is to avoid a long delay when shutting down the broker.
Closes #1735 . Thanks to Colin Law.
2020-08-04 11:17:04 +01:00
Roger A. Light
1f717873d6
Log protocol error message where appropriate from a bad UNSUBSCRIBE
...
Rather than the generic "socket error".
Related to #1765 .
2020-07-31 23:01:15 +01:00
Roger A. Light
2b1a22776b
Only call setvbuf on open files.
2020-07-19 21:59:28 +01:00
Roger A. Light
19d65ba200
Set ownership of docker files on startup.
2020-07-17 22:35:11 +01:00
Roger A. Light
54f3b686dc
Fix "slow" file based logging by switching to line based buffering.
...
Closes #1689 . Closes #1741 . Thanks to Brett M. Gordon and tt92.
2020-07-15 22:28:19 +01:00
Roger A. Light
8234d24b1b
Fix websockets clients sometimes not being disconnected promptly.
...
Closes #1718 . Thanks to Luca Casonato.
2020-07-15 22:06:29 +01:00
Roger A. Light
d371b3c58b
Fix mosquitto_publish*()
no longer returning MOSQ_ERR_NO_CONN
.
...
This was always returning success when the client was not connected.
Closes #1725 . Thanks to BOTorioN.
2020-07-15 20:25:36 +01:00
Roger A. Light
b4e0dfa598
Fix autosave_interval
not being triggered by messages being delivered.
...
Closes #1726 . Thanks to nduhme.
2020-07-15 19:29:40 +01:00
Roger A. Light
4e0312c55f
Fix messages being queued for disconnected bridges
...
This occurred incorrectly when clean start was set to true.
Closes #1729 . Thanks to Andreyooo.
2020-07-15 17:08:00 +01:00
Roger A. Light
d9003bb858
Don't use mutex until it is initialised.
...
Coverity Scan 1430456.
2020-07-15 12:12:51 +01:00
Roger A. Light
e272f8fbca
mosquitto_pub: Close file on file too large.
...
This wasn't a problem because this error caused the program to
exit, so there was no real resource leak.
Coverity Scan 1430457.
2020-07-15 12:04:20 +01:00
Roger A. Light
cadcde52a4
Remove duplicate code.
...
Coverity Scan 1430458.
2020-07-15 12:00:29 +01:00
Roger A. Light
1d66d3e443
Fix bridge topic remapping when using "" as the topic.
...
Closes #1749 . Thanks to cieslarchristian.
2020-07-15 00:19:44 +01:00
Roger A. Light
5a56f066a8
Change systemd unit files to create /var/log/mosquitto
...
This happens before starting the broker.
Also don't quit with an error if opening the log file isn't possible.
Closes #821 .
2020-07-14 20:10:54 +01:00
Roger A. Light
abb31ffe8d
Fix broker refusing to start if only websockets listeners were defined.
...
Closes #1740 . Thanks to OkenKhuman.
2020-07-14 17:27:57 +01:00
Sigmund Vik
5481575f8b
Fix FormatMessage warnings for Windows.
...
From the FormatMessage() Win32 API documentation: "The lpBuffer
parameter is a pointer to an LPTSTR; you must cast the pointer
to an LPTSTR (for example, (LPTSTR)&lpBuffer)."
https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-formatmessage#parameters
This commit fixes warnings like these:
warning C4047: 'function': 'LPSTR' differs in levels of indirection from 'char **'
warning C4024: 'FormatMessageA': different types for formal and actual parameter 5
Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>
2020-07-12 22:34:20 +01:00
Sigmund Vik
a75d574870
Fix sys_tree macro stubs with no arguments.
...
This fixes Visual Studio compiler warnings like this one:
"warning C4003: not enough arguments for function-like
macro invocation 'G_MSGS_DROPPED_INC'"
Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>
2020-07-12 22:26:00 +01:00
Sigmund Vik
20972a2819
Add broker ready message.
...
Before this commit there was no good way to detect that the
Mosquitto broker was done with its startup phase on systems
without systemd.
On such systems it was tricky to e.g. start the broker from
a test where ports are dynamically assigned and one have to
deal with potential port conflicts. Without a way to know
that the broker is done with its startup phase, there was no
way to know if the broker was able to acquire the port (for
both IPv4 and IPv6) without waiting for some unknown period
of time (when many tests are run in parallel a single process
might be starved for resources).
With this new broker ready message it is easy for the parent
process to monitor the broker output and figure out when the
port was successfully acquired.
Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>
2020-07-10 22:48:58 +01:00
Roger A. Light
c8964228e3
Improved documentation around connect callback return codes.
...
Close #1730 . Thanks to John Laird.
2020-06-22 21:45:50 +01:00
Jasper Lievisse Adriaanse
4ef7ea6244
extend ifdef guard to fix compilation on OpenBSD
...
otherwise in6_addr, AF_INET and AF_INET6 end up being undefined
Signed-off-by: Jasper Lievisse Adriaanse <jasper@humppa.nl>
2020-06-17 15:54:24 +01:00
Jasper Lievisse Adriaanse
2758401829
only link with libm on OpenBSD
...
fixes "ld: error: unable to find library -ldl"
Signed-off-by: Jasper Lievisse Adriaanse <jasper@humppa.nl>
2020-06-17 15:54:24 +01:00
HowJMay
40a23981d3
fix typos in examples
...
Fix typos
Signed-off-by: HowJMay <vulxj0j8j8@gmail.com>
2020-06-17 15:52:00 +01:00
Roger A. Light
0946dc3a8d
Release post.
2020-06-17 15:52:00 +01:00
Roger A. Light
faf0530a76
Update example Docker ports.
...
Port 9001 is used by Intel drivers on Windows, so some users are
suddenly seeing a problem.
Issue #1580 .
2020-06-17 15:52:00 +01:00
Roger A. Light
9313f09c9d
Updated pull rqeuest text.
2020-06-17 15:52:00 +01:00
Roger A. Light
09db90c41a
Bump dockerfile for 1.6.9.
2020-06-17 15:52:00 +01:00
Roger A. Light
a9c97efaa4
Document that keepalive must be >= 5 seconds.
2020-06-10 15:21:01 +01:00
Roger A. Light
4b541ad5ca
Fix usage message not mentioning v5.0.
...
Closes #1713 . Thanks to whnr.
2020-06-09 15:42:51 +01:00
matt
ee634e4f84
replace broken ssl-libs
...
Signed-off-by: matt <swineherd92@gmail.com>
2020-06-09 15:24:40 +01:00
Roger A. Light
d95513ae15
Man pages generated as part of web page, so no need to copy.
2020-05-25 23:41:17 +01:00
Roger A. Light
cea0423e69
Update changelog and version.
2020-05-25 23:40:15 +01:00
Roger A. Light
6bd435d721
Fix possible assert crash associated with bridge reconnecting.
...
This only occurs when compiled without epoll support.
Closes #1700 . Thanks to Matthias Urlichs.
2020-05-25 23:38:13 +01:00
Roger A. Light
ce463c185b
Update changelog.
2020-05-20 11:02:11 +01:00
Martin Kelly
d103174b5c
correct mosquitto.h return code documentation
...
We currently erroneously claim that mosquitto_lib_init cannot fail,
while it can fail on Windows, if WSAStartup fails in net__init. Correct
this.
Signed-off-by: Martin Kelly <mkelly@xevo.com>
2020-05-20 10:59:00 +01:00
Martin Kelly
61a50c60d2
add a refcount to library init/cleanup
...
Add a refcount around mosquitto_lib_init and mosquitto_lib_cleanup so
that multiple calls to init/cleanup don't trigger memory leaks or
double-frees.
Signed-off-by: Martin Kelly <mkelly@xevo.com>
2020-05-20 10:57:40 +01:00
Roger A. Light
eae8c9aab4
Fix check when loading persistence file of a different version
...
Closes #1684 . Thanks to grekhss.
2020-05-15 22:11:26 +01:00
Roger A. Light
762ad432e8
Fix support for openssl 3.0
2020-05-12 13:39:49 +01:00
Roger A. Light
24049b1a1e
Fix mosquitto_sub %j or %J not working on Windows.
...
Closes #1674 . Thanks to amigian74.
2020-05-06 22:24:58 +01:00
Roger A. Light
c343812c42
Improve client test for unexpected pubrel.
2020-05-05 23:25:42 +01:00
Roger A. Light
946257bf30
Remove spurious version heading.
2020-05-05 16:01:17 +01:00
Roger A. Light
b2e72a7e7c
Fix memory leaks only in tests.
2020-05-05 14:19:04 +01:00
Roger A. Light
bfc82ea91a
Fix incorrect check.
2020-05-05 13:13:24 +01:00
Roger A. Light
4960fc0702
Don't disconnect clients that are already disconnected.
...
This prevents the session expiry being extended on SIGHUP.
Closes #1521 . Thanks to Christoph Krey.
2020-05-01 22:45:40 +01:00
Roger A. Light
eeaafed485
Fix memory leak when connecting clients rejected.
2020-04-30 17:31:13 +01:00
Roger A. Light
5908585afd
Fix mosquitto_passwd -b not updating passwords for existing users
...
Closes #1664 . Thanks to Leon Kiefer.
2020-04-26 22:44:57 +01:00
Roger A. Light
40bad1a999
Fix conversion warnings in client code
...
Issue #1653 .
2020-04-16 23:26:14 +01:00
Roger A. Light
3758e0c328
Fix mosquitto_passwd not being able to create pwfile with -b.
2020-04-08 12:38:15 +01:00
Roger A. Light
fdaeaee6dd
Fix test.
2020-04-07 16:10:02 +01:00
Roger A. Light
3e9eae401e
Missing / in bridge remapping doc.
2020-03-31 10:13:20 +01:00
Roger A. Light
904284595f
Add missing test file.
2020-03-30 20:47:30 +01:00