Commit Graph

2855 Commits

Author SHA1 Message Date
Roger A. Light
436f0b9348 dynsec: Fix modifyClient and modifyGroup commands
They will now not modify the client/group if a new group/client being
added is not valid, or on other failures.

Closes #2598. Thanks to Sebastian Szczepański.
2022-08-16 00:48:02 +01:00
Roger A. Light
b22df5140e Clear errno before check. 2022-08-16 00:23:06 +01:00
Roger A. Light
49ebb58569 Fix failure to close thread in some situations.
Closes #2545. Thanks to p-luke.
2022-08-15 22:17:00 +01:00
Roger A. Light
fa31b6f41d Fix bridge queued messages not being persisted.
This happens when local_cleansession is set to false and cleansession is
set to true.

Closes #2604. Thank to Frank Dekervel.
2022-08-13 22:46:19 +01:00
Roger A. Light
5d18962486 Improve custom SSL_CTX tests.
Issue #2463.
2022-08-12 08:52:40 +01:00
Roger A. Light
80c7726d5c Fix confusing error message when dynamic security config file was a directory.
Closes #2520. Thanks to sezanzeb
2022-08-12 08:34:56 +01:00
Roger A. Light
775bd2effd Fix confusing "out of memory" error.
This happens when a client is kicked in the dynamic security plugin.

Closes #2525. Thanks to sezanzeb.
2022-08-12 08:17:17 +01:00
Roger A. Light
c4664f08ac Clarify use_username_as_clientid is not global 2022-08-11 11:51:53 +01:00
Roger A. Light
02b92b97ef Fix use of MOSQ_OPT_SSL_CTX when used with MOSQ_OPT_SSL_CTX_DEFAULTS
Closes #2463. Thanks to Tim Nordell.
2022-08-10 17:18:33 +01:00
Roger A. Light
f9fa19ce6a - Fix -o not working in mosquitto_ctrl, and typo in related documentation.
Closes #2471. Thanks to Vitaljok and rillbert
2022-08-10 15:14:32 +01:00
Roger A. Light
6468bb4f9b Fix documentation omission around mosquitto_reinitialise.
Closes #2489. Thanks to rroguski
2022-08-10 14:31:34 +01:00
Roger A. Light
351911bd8f Fix incorrect return code being sent in DISCONNECT.
This is for when a client session is taken over.

Closes #2607. Thanks to der-b
2022-08-10 14:17:22 +01:00
Roger A. Light
08610f7c99 Further fix for #2546. 2022-08-09 21:25:55 +01:00
Roger A. Light
e979a46c04 Backport SSL connect fixes.
Closes #2594.
Closes #2595.
2022-08-09 21:25:54 +01:00
Roger A. Light
a913de2d28 Fix some PUBLISH messages not being counted in $SYS stats.
Closes #2448. Thanks to Antoine.
2022-08-08 00:29:37 +01:00
Roger A. Light
ba6bbd5959 Add documentation of struct mosquitto_message to header.
Closes #2561.
2022-08-08 00:01:56 +01:00
Roger A. Light
0c9d9f2163 Don't set SIGPIPE to ignore, use MSG_NOSIGNAL instead.
Closes #2564. Thanks to nmeum.
2022-08-07 23:04:46 +01:00
Roger A. Light
8c0600c40c Fixed build for openssl compiled with OPENSSL_NO_ENGINE.
Closes #2589. Thanks to Dirk Feytons.
2022-08-06 23:16:55 +01:00
Roger A. Light
a146c218ad Fix unlimited message quota not being properly checked.
This is for incoming messages.

Closes #2593. Thanks to dongguoqing2015.
2022-08-06 22:49:08 +01:00
Roger A. Light
71a90177d7 Systemd: Add mosquitto group ownership
Thanks to minfrin
2022-07-20 17:03:42 +01:00
Roger A. Light
2e061afcc6 Fix build 2022-06-03 20:49:59 +01:00
Roger A. Light
ebfebf8708 Fix bridges not sending failure notification messages.
This is for messages to the local broker if the remote bridge connection
fails.

Closes #1488.
Closes #2467.
2022-05-25 16:23:35 +01:00
Roger A. Light
3e1cf8a80b Fix tests build. 2022-05-25 16:16:48 +01:00
Roger A. Light
c99502a256 Add clients to session expiry check list when restarting and reloading from persistence.
Closes #2546. Thanks to Joachim Schachermayer.
2022-05-23 23:05:49 +01:00
Roger A. Light
80b36919b1 Fix incorrect pointer use. 2022-05-23 22:38:02 +01:00
Roger A. Light
29c6480c47 Improve documentation of persistent_client_expiration option.
Closes #2404. Thanks to Rainer Plischke.
2022-05-19 17:04:20 +01:00
Roger A. Light
09ac578459 Fix unused flags in CONNECT command being forced to be 0 in MQTT v3.1
This check is not required until v3.1.1.

Closes #2522. Thanks to garinocyr
2022-05-17 17:41:57 +01:00
Roger A. Light
b6b8039914 Fix use of MOSQ_OPT_TLS_ENGINE being unable to be used.
This was due to the openssl ctx not being initialised until starting to connect.

Closes #2537. Thanks to chessing-c4.
2022-05-17 17:19:17 +01:00
Roger A. Light
127c5e7577 Update changelog 2022-05-11 15:55:05 +01:00
Roger A. Light
45a6b89e91 Merge branch 'abiliojr-fix_msg_modification_leak' into fixes 2022-05-11 15:53:59 +01:00
Roger A. Light
53a9e81480 Merge branch 'fix_msg_modification_leak' of https://github.com/abiliojr/mosquitto into abiliojr-fix_msg_modification_leak 2022-05-11 15:53:48 +01:00
JsBergbau
651331ff7d Added queue_qos0_messages documentation for bridging
See https://github.com/eclipse/mosquitto/pull/2500
2022-05-11 15:51:59 +01:00
Roger Light
82dff0f32d
Merge pull request #2510 from csalve/fix-missing-mutex-for-next_msg_out
fix data race mosquitto_loop function
2022-04-29 22:29:40 +01:00
Roger A. Light
0745a8536a Update changelog.
Fix mosquitto_pub incorrectly reusing topic aliases when reconnecting.

Closes #2494.
2022-04-29 22:20:15 +01:00
Roger Light
d0d8f1a83d
Merge pull request #2513 from Daedaluz/fixes
Don't reuse topic alias after reconnect.
2022-04-29 22:18:52 +01:00
Tobias Assarsson
a9a5ac2283 Don't reuse topic alias after reconnect. 2022-04-20 10:04:58 +02:00
Christian Salvasohn
4077987593 fix data race mosquitto_loop function
next_msg_out must be protected with the msgtime_mutex
as done everywhere else in the code else there is a data race
e.g. if mosquitto_publish is called from another thread

Signed-off-by: Christian Salvasohn <csalvasohn@gmx.de>
2022-04-13 20:05:35 +02:00
Roger Light
3cdeb595ff
Merge pull request #2504 from Hallot/fix/cmake-mosquitto-as-submodule
CMake: Use PROJECT_SOURCE_DIR to improve using mosquitto as subdirectory
2022-04-11 23:50:49 +01:00
Pierre Hallot
8504f6b70b
CMake: Use PROJECT_SOURCE_DIR to improve using mosquitto as subdirectory
When mosquitto is included as subdirectory, `CMAKE_SOURCE_DIR` does not refer to the mosquitto top level CMake file, but to the whole project top level CMake.
Use `PROJECT_SOURCE_DIR` instead to refer to the right CMake in both contextes.

Signed-off-by: Pierre Hallot <hallotpierre@gmail.com>
2022-04-05 16:14:48 +02:00
Abilio Marques
3c48b501e0 broker: fix memory leaks on plugin payload modification
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
2022-03-13 08:48:00 +01:00
Roger A. Light
74814cc68f Simplify cmake threads detection on Windows
Requires cmake 3.1.
2022-02-24 19:04:29 +00:00
Roger A. Light
ffe952f9c7 Merge branch 'podsvirov-win-threads' into fixes 2022-02-24 18:55:48 +00:00
Roger A. Light
49b1d7dfbd Merge branch 'win-threads' of https://github.com/podsvirov/mosquitto into podsvirov-win-threads 2022-02-24 18:55:40 +00:00
Roger A. Light
fc06da2daa Fix pthreads linkage. 2022-02-24 17:01:42 +00:00
Roger A. Light
1e9d00a1a1 Update changelog 2022-02-24 15:56:46 +00:00
Roger Light
fad0b39eaa
Merge pull request #2408 from tjlusco/constant-restart-timeout-fix
Fix constant restart_timeout
2022-02-24 15:55:36 +00:00
Roger A. Light
39f3030643 Fix client_generated flag not being copied on properties.
Closes #2401. Thanks to Diorcet Yann.
2022-02-24 14:05:11 +00:00
Roger A. Light
41b1b0c6d1 Merge branch 'XavierDooms-fix-support-tick-with-per-listener-settings' into fixes 2022-02-24 13:48:41 +00:00
Roger A. Light
62c0d0c9c8 Merge branch 'fix-support-tick-with-per-listener-settings' of https://github.com/XavierDooms/mosquitto into XavierDooms-fix-support-tick-with-per-listener-settings 2022-02-24 13:26:06 +00:00
Roger A. Light
96931643a4 Use strings.h for strcasecmp, except on Windows.
Closes #2420. Thanks to Frédéric Fauberteau.
2022-02-24 12:02:16 +00:00