Roger A. Light
0bdf630c27
Merge branch 'fixes'
2020-08-19 14:47:27 +01:00
Roger A. Light
39ff7226eb
Bump version, add new www posts.
2020-08-19 14:46:44 +01:00
Roger A. Light
c1b009e4df
Fix memory leak on handling QoS 2 PUBLISH.
...
In some circumstances, Mosquitto could leak memory when handling PUBLISH messages. This is limited to incoming QoS 2 messages, and is related to the combination of the broker having persistence enabled, a clean session=false client, which was connected prior to the broker restarting, then has reconnected and has now sent messages at a sufficiently high rate that the incoming queue at the broker has filled up and hence messages are being dropped. This is more likely to have an effect where max_queued_messages is a small value. This has now been fixed.
Closes #1793 . Thanks to mbates14.
2020-08-19 14:38:57 +01:00
Roger A. Light
b3b58cc635
Build warning fixes.
2020-08-19 14:04:02 +01:00
Roger A. Light
4dc835b73d
Fix possible memory leaks on errors during persistence write.
2020-08-19 11:12:05 +01:00
Titouan Christophe
79051fbdca
do not include pthread when compiling without threading support
...
This fixes the following error, when compiling for systems without
pthread support, and when passing WITH_THREADING=no to make:
thread_mosq.c:24:12: fatal error: pthread.h: No such file or directory
# include <pthread.h>
^~~~~~~~~~~
compilation terminated.
Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
2020-08-18 22:52:29 +01:00
Karl Palsson
2fdb5a0171
docs: move _string_option with rest of client options
...
It was grouped with the callbacks, where it didn't make a lot of sense.
Signed-off-by: Karl Palsson <karlp@tweak.net.au>
2020-08-18 22:51:42 +01:00
Karl Palsson
d254ea70df
docs: remove duplicate mosquitto_reconnect_delay_set
...
Was listed in both client options, and under the callbacks.
Signed-off-by: Karl Palsson <karlp@tweak.net.au>
2020-08-18 22:51:42 +01:00
Roger A. Light
367a282c61
Don't quit on chmod error, it can be ignored.
2020-08-13 20:51:26 +01:00
Roger A. Light
a224a8f217
Don't busy loop with mosquitto_pub -l
on a slow connection.
2020-08-13 14:32:47 +01:00
Roger A. Light
6407abf717
Docker: Fix missing libressl library.
2020-08-12 22:08:05 +01:00
Roger A. Light
ac3b30ca4f
Fix docker command override.
2020-08-12 17:00:53 +01:00
Roger A. Light
124225d02b
Update docker.
2020-08-12 16:03:08 +01:00
Roger A. Light
9929ce0a26
All clients exit with an error exit code on CONNACK failure.
...
Closes #1778 . Thanks to jflambert.
2020-08-12 09:44:42 +01:00
Roger A. Light
32ed4809ed
Build fix for NetBSD.
...
Thanks to Greg Troxel.
2020-08-11 16:21:19 +01:00
Roger A. Light
f89cea2bc5
Update webpage.
2020-08-11 12:13:38 +01:00
Roger A. Light
94295b5d74
Merge branch 'fixes'
2020-08-11 12:07:56 +01:00
Roger A. Light
c9218fd48c
Bump version.
2020-08-11 12:05:32 +01:00
Roger A. Light
b3c2ac20dc
Fix overly broad HAVE_PTHREAD_CANCEL compile guard.
...
Closes #1547 . Thanks to Markus Gothe.
2020-08-11 11:02:38 +01:00
Roger A. Light
4b100df5b1
Fix reconnect+will delay interval issue causing missing messages.
...
Fix clients not receiving messages after a previous client with the same client ID and positive will delay interval quit.
Closes #1752 . Thanks to Jiří Zuzaňák.
2020-08-11 11:01:25 +01:00
Roger Light
60dc8f5e4c
Fix service path quoting on Windows.
...
https://bugs.eclipse.org/bugs/show_bug.cgi?id=565671
2020-08-11 09:09:31 +01:00
Roger Light
4ef48269f5
Fix mosquitto_loop_stop() not stopping on Windows
...
Closes #1748 . Closes #117 . Thanks to Sigmund Vik.
2020-08-11 08:55:05 +01:00
Roger Light
3eb60e2e6a
Fix some winsock argument types.
2020-08-11 08:43:24 +01:00
Roger A. Light
bd27935ff6
mosquitto_loop_start()
now sets a thread name.
...
This applies on Linux, FreeBSD, NetBSD, and OpenBSD.
Closes #1777 . Thanks to ABuch19.
2020-08-10 22:51:17 +01:00
Roger A. Light
ebb0f13f08
Merge branch 'dbeinder-improve-client-store' into fixes
2020-08-07 16:40:18 +01:00
Roger A. Light
43df213ecb
Merge branch 'improve-client-store' of git://github.com/dbeinder/mosquitto into dbeinder-improve-client-store
2020-08-07 09:11:43 +01:00
david-beinder
c11d20f82c
Database v6 tests
...
keep v5 client read test to test for backwards compatability
adds username="usrname" and listener_port=1883 for v6 tests
Signed-off-by: david-beinder <david.beinder@mce.li>
2020-08-07 08:56:52 +02:00
david-beinder
212fd8635f
Store username and listener of persistent clients
...
Signed-off-by: david-beinder <david.beinder@mce.li>
2020-08-07 08:32:14 +02:00
Roger A. Light
94d04136f8
Fix potential memory leaks.
...
Closes #1773 . Closes #1774 . Thanks to Yingpei Zeng.
2020-08-06 21:28:09 +01:00
Roger A. Light
5f565fe4ea
Previous change to only update on difference causes errors :(
2020-08-06 12:50:18 +01:00
Roger A. Light
a38cb3bf51
Branch sync - only sync when there is a difference to avoid errors.
2020-08-04 12:25:49 +01:00
Roger A. Light
618cd7006b
Don't try to start DLT logging if DLT unavailable.
...
This is to avoid a long delay when shutting down the broker.
Closes #1735 . Thanks to Colin Law.
2020-08-04 11:17:04 +01:00
Roger A. Light
1f717873d6
Log protocol error message where appropriate from a bad UNSUBSCRIBE
...
Rather than the generic "socket error".
Related to #1765 .
2020-07-31 23:01:15 +01:00
Roger A. Light
0ac46c2d2a
core18 doesn't have libssl1.1
2020-07-22 20:36:29 +01:00
Roger A. Light
42ab1fe2d3
Upgrade snap to core18.
2020-07-22 15:13:40 +01:00
Roger A. Light
2b1a22776b
Only call setvbuf on open files.
2020-07-19 21:59:28 +01:00
Roger A. Light
19d65ba200
Set ownership of docker files on startup.
2020-07-17 22:35:11 +01:00
Roger A. Light
54f3b686dc
Fix "slow" file based logging by switching to line based buffering.
...
Closes #1689 . Closes #1741 . Thanks to Brett M. Gordon and tt92.
2020-07-15 22:28:19 +01:00
Roger A. Light
8234d24b1b
Fix websockets clients sometimes not being disconnected promptly.
...
Closes #1718 . Thanks to Luca Casonato.
2020-07-15 22:06:29 +01:00
Roger A. Light
d371b3c58b
Fix mosquitto_publish*()
no longer returning MOSQ_ERR_NO_CONN
.
...
This was always returning success when the client was not connected.
Closes #1725 . Thanks to BOTorioN.
2020-07-15 20:25:36 +01:00
Roger A. Light
b4e0dfa598
Fix autosave_interval
not being triggered by messages being delivered.
...
Closes #1726 . Thanks to nduhme.
2020-07-15 19:29:40 +01:00
Roger A. Light
4e0312c55f
Fix messages being queued for disconnected bridges
...
This occurred incorrectly when clean start was set to true.
Closes #1729 . Thanks to Andreyooo.
2020-07-15 17:08:00 +01:00
Roger A. Light
d9003bb858
Don't use mutex until it is initialised.
...
Coverity Scan 1430456.
2020-07-15 12:12:51 +01:00
Roger A. Light
e272f8fbca
mosquitto_pub: Close file on file too large.
...
This wasn't a problem because this error caused the program to
exit, so there was no real resource leak.
Coverity Scan 1430457.
2020-07-15 12:04:20 +01:00
Roger A. Light
cadcde52a4
Remove duplicate code.
...
Coverity Scan 1430458.
2020-07-15 12:00:29 +01:00
Roger A. Light
3a83bafe40
Github actions: Add workflow_dispatch to allow a manual trigger.
2020-07-15 11:26:23 +01:00
Roger A. Light
80bb31cf48
Github action for synchronising coverity scan branches
2020-07-15 11:10:10 +01:00
Roger A. Light
1d66d3e443
Fix bridge topic remapping when using "" as the topic.
...
Closes #1749 . Thanks to cieslarchristian.
2020-07-15 00:19:44 +01:00
Roger A. Light
5a56f066a8
Change systemd unit files to create /var/log/mosquitto
...
This happens before starting the broker.
Also don't quit with an error if opening the log file isn't possible.
Closes #821 .
2020-07-14 20:10:54 +01:00
Roger A. Light
abb31ffe8d
Fix broker refusing to start if only websockets listeners were defined.
...
Closes #1740 . Thanks to OkenKhuman.
2020-07-14 17:27:57 +01:00