Roger A. Light
b0a065f790
Update changelog. Release page. Bump copyright.
2020-02-27 23:26:58 +00:00
Roger A. Light
c2ec6f002e
Fix test to match fixed protocol check.
2020-02-27 23:12:28 +00:00
Roger A. Light
0c68c20d2b
Fix mosquitto_client_protocol()
returning incorrect values.
2020-02-27 15:01:41 +00:00
Roger A. Light
db02c9162d
Add plugin that prints out calls, to help debugging.
2020-02-27 15:01:41 +00:00
Roger A. Light
032af6bf69
Add missing header
2020-02-27 15:01:41 +00:00
Roger A. Light
3ff0d04910
Update test key length to 2048 to avoid new openssl rejections.
2020-02-25 14:54:25 +00:00
Roger A. Light
b6a54a21d8
Remove duplicate code.
2020-02-12 16:47:46 +00:00
Roger A. Light
8d5fd7d1e2
Fix mosquitto_topic_matches_sub()
behaviour with wildcards in topic.
...
It was not returning MOSQ_ERR_INVAL if the topic contains a wildcard.
Closes #1589 . Thanks to mdelete.
2020-02-07 22:55:50 +00:00
Roger A. Light
f16d9e2bcf
Add file missing from earlier commit.
2020-02-06 21:06:03 +00:00
Roger A. Light
c4e41f3444
Back port db_dump from develop.
...
Closes #1519 . Thanks to Christoph Krey.
2020-02-06 16:44:04 +00:00
Roger A. Light
2a8c1d03f5
Merge branch 'coverity-fixes' into fixes
2020-02-06 16:20:52 +00:00
Roger A. Light
17e20de9e7
Fix session-expiry-interval for v5 clients using -c.
...
Default behaviour for v5 clients using `-c` is now to use infinite length
sessions, as with v3 clients.
Closes #1546 . Thanks to Kiran Pradeep.
2020-02-06 16:14:29 +00:00
Roger A. Light
019d4214b8
Fix session-expiry-interval for v5 clients using -c.
...
Default behaviour for v5 clients using `-c` is now to use infinite length
sessions, as with v3 clients.
Closes #1546 . Thanks to Kiran Pradeep.
2020-02-06 16:12:56 +00:00
Gianfranco Costamagna
078ad752cd
cmake: add ADNS enable/disable dynamic support
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
2020-02-06 15:24:09 +00:00
Gianfranco Costamagna
e9a7150031
Bugfix: enabling DLT was overriding everything else on linker flags because of error in cmake set keyword
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
2020-02-06 15:21:40 +00:00
Gianfranco Costamagna
7a5c2d4da5
Bugfix: include "deps" directory only if BUNDLED_DEPS has been provided and set to true
...
Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
2020-02-06 15:20:29 +00:00
Roger A. Light
56d0b950ac
Fix --remove-retained
not obeying the -T
option.
...
This means `--remove-retained -t bbc/# -T bbc/one/#` would remove all
retained messages in `bbc/#`, instead of leaving all of the topics in
`bbc/one/#`.
Closes #1585 . Thanks to Simon Moser.
2020-02-05 15:19:55 +00:00
Roger A. Light
3a89059271
Don't call SSL_shutdown() if SSL init hasn't completed.
2020-02-04 17:11:11 +00:00
Roger A. Light
07c54627e9
Print OpenSSL errors in more situations
...
Covers when loading certificates fails, or there are ENGINE problems.
Closes #1552 . Thanks to Michael Richardson.
2020-02-04 16:59:29 +00:00
Roger A. Light
27b4518d7e
Improve password file parsing in the broker and mosqitto_passwd.
...
Closes #1584 . Thanks to panava.
2020-02-04 16:38:51 +00:00
Roger A. Light
ed5db1bd6b
Fix bind_interface
not working for the default listener.
...
Closes #1533 . Thanks to Markus Gothe.
2020-01-30 22:48:15 +00:00
Roger A. Light
e188a6b500
More whitespace trimming fixes/consolidation.
2020-01-30 22:26:13 +00:00
Roger A. Light
32969169f7
Trim whitespace from acl topics.
2020-01-30 19:55:55 +00:00
Roger A. Light
70fd600c3a
Fix trailing whitespace not being trimmed on acl users.
...
Closes #1539 . Thanks to CliveJL and LeonPoon.
2020-01-30 19:52:46 +00:00
Roger A. Light
9a0de5ef61
Free log_timestamp_format on exit.
...
Closes #1523 . Thanks to Basavesh Shivakumar.
2020-01-30 16:19:10 +00:00
Roger A. Light
81641df043
Expose net__print_ssl_error() prototype.
2020-01-30 15:14:52 +00:00
Roger A. Light
17db97584e
Fix client keepalive test using too low keepalive.
2020-01-30 15:06:15 +00:00
Roger A. Light
11ece604c4
Merge branch 'bugfix-MemLeak_in_handle_unsubscribe' of git://github.com/panava/mosquitto into panava-bugfix-MemLeak_in_handle_unsubscribe
2020-01-30 14:22:12 +00:00
Roger A. Light
89b55094c0
Merge branch 'bugfix-NullDeref_in_util_mosc.c' of git://github.com/panava/mosquitto into panava-bugfix-NullDeref_in_util_mosc.c
2020-01-30 12:43:09 +00:00
Roger A. Light
3220790790
Merge branch 'bugfix-MemoryLeak_in_persist_read' of git://github.com/panava/mosquitto into panava-bugfix-MemoryLeak_in_persist_read
2020-01-30 12:40:16 +00:00
Roger A. Light
08de10ae43
Distribute clients with 1.5 docker image.
...
Closes #1548 .
2020-01-30 12:36:39 +00:00
Roger A. Light
f67b3d4e98
Merge branch 'master' into fixes
2020-01-30 12:23:56 +00:00
Roger A. Light
3671a6dfdb
Add -x
argument to all clients.
...
This allows the session-expiry-interval property to be easily set for
MQTT v5 clients.
2020-01-30 11:19:09 +00:00
Roger A. Light
4e1e0f955f
Record of which client argument letters are in use.
2020-01-30 11:09:04 +00:00
Roger A. Light
50735afb5b
Fix for internal logging not printing.
2020-01-29 16:25:56 +00:00
Panagiotis Vasilikos
618413e1d2
Resource leak in persist_read.c
...
Reason: In lines 435 and 439, the function returns without calling closing
fptr which was opened at line 399.
Fix: I added fclose(fptr) statements before each of the returns.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
2020-01-29 13:30:24 +01:00
Panagiotis Vasilikos
dd6d8237cb
Potential Null pointer dereference in util_mosq.c
...
Reason: There is no check that the mosquitto__malloc at line 162 was sucessfull.
This could result to a Null pointer dereference in the memcpy call at line 166.
Fix: I added the check.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
2020-01-29 10:17:58 +01:00
Roger A. Light
8f1c8cba59
Set minimum keepalive argument to mosquitto_connect*()
to be 5 seconds.
...
Closes #1550 . Thanks to Markus Gothe.
2020-01-28 16:59:20 +00:00
Roger A. Light
9ae38788dc
Fix config->user not being freed on exit.
...
Closes #1564 . Thanks to back1127.
2020-01-28 16:52:14 +00:00
Roger A. Light
812c0636d5
Satisfy valgrind when exiting on error.
...
This is when due to not being able to open a listening socket, solved by
calling freeaddrinfo in the error cases.
Closes #1565 . Thanks to back1127.
2020-01-28 16:12:45 +00:00
Roger A. Light
e7c9f009bd
Strip whitespace from end of config file string options.
...
Closes #1566 . Thanks to kollokollo.
2020-01-28 16:04:25 +00:00
Panagiotis Vasilikos
49bf788862
Memory leak in handle_unsubscribe.c
...
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.
Fix: I added a mosquitto__free(reason_codes) statement before each return
statement that could result to a memory leak
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
2020-01-28 16:31:15 +01:00
Panagiotis Vasilikos
caeb211cc5
Memory leak in socks_mosq.c
...
Reason: The memory allocated for the packet pointer at line 155 is not freed
before returning at line 188.
Fix: I inserted the mosquitto__free(packet) statement just before returning
at line 188.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
2020-01-28 11:34:11 +01:00
Panagiotis Vasilikos
0f7052564c
Memory leak in handle_unsubscribe.c
...
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.
Fix: I moved the memory allocation code block (lines 69-73) just before
the line 102. This is the first place the pointer reason_codes is used, while
the following mosquitto__free operators free the allocated memory correctly.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
2020-01-24 16:34:56 +01:00
Roger A. Light
4408339dbc
Make consts unsigned where they are compared against unsigned.
2020-01-23 12:51:47 +00:00
Roger A. Light
5528dde56a
Fix possible null dereferences.
2020-01-23 12:51:12 +00:00
Roger A. Light
05ec02b3f3
Remove dead values.
2020-01-23 10:55:49 +00:00
Roger A. Light
18f0508a6e
Fix dereference before null check.
...
Coverity Scan 1405815.
2020-01-23 10:08:26 +00:00
Roger A. Light
db62f9843f
Fix unused value being overwritten.
...
Coverity Scan 1400727.
2020-01-23 09:35:28 +00:00
Roger A. Light
6aa9b91fff
Add testing
target for compiling test client fixes.
2020-01-02 21:40:03 +00:00