Commit Graph

2673 Commits

Author SHA1 Message Date
Roger A. Light
2749b8c5b8 Merge branch 'fixes' 2021-01-28 12:28:53 +00:00
Roger A. Light
e98cc28cd3 Move check after current_out_packet is updated. 2021-01-28 09:29:52 +00:00
Przemek Zygmunt
18bad1ff32 Unconditionally adding an event to the epoll causes 100% CPU usage. This happens when the connection to the server is established and the client has not sent any data yet.
Signed-off-by: Przemek Zygmunt <p.zygmunt@acsoftware.pl>
2021-01-28 09:28:36 +00:00
Roger A. Light
6e3738dcf0 Fix bridges not always connecting on Windows.
Closes #2043. Thanks to ttsorensen.
2021-01-26 13:19:08 +00:00
Roger Light
ad9a78dfc3 Note in the man pages that SIGHUP reloads TLS certificates.
Closes #2037. Thanks to Greg Troxel.
2021-01-25 23:09:03 +00:00
Roger A. Light
706a1f3f29 Fix more minor compiler warnings. 2021-01-21 13:33:54 +00:00
Roger A. Light
cda84950bb Fix mux_epoll__handle() use. 2021-01-21 12:06:45 +00:00
Roger A. Light
a4389fc9ce Fix SPDX identifiers: EDL-1.0 -> BSD-3-Clause.
The two licenses are the same.
2021-01-20 11:46:18 +00:00
Roger A. Light
cf1098eff1 Send protocol error on topic alias not found.
The error topic-alias-invalid was being sent if an MQTT v5 client published
a message with empty topic and topic alias set, but the topic alias hadn't
already been configured on the broker. This has been fixed to send a
protocol error, as per section 3.3.4 of the specification.
2021-01-20 10:28:40 +00:00
Roger A. Light
3c58ac9308 Fix message_size_limit not applying to the Will payload.
Closes #2022. Thanks to Umberto Morelli.
2021-01-19 11:51:50 +00:00
Roger A. Light
4165224885 Fix reloading of listeners where multiple listeners have the same port.
This is only possible where they have different bind addresses.

Closes #2029. Thanks to Simon Aldrich.
2021-01-19 10:16:06 +00:00
Roger A. Light
c9a4ef402e Update changelog. 2021-01-19 10:15:11 +00:00
Roger Light
e6aa1e8151
Merge pull request #2027 from madhat1/bugfix/fix_cjson_cmake
Fix cmake not building correctly when WITH_CJSON=OFF
2021-01-19 09:39:16 +00:00
Boris Feinstein
c16514ca23 perform cjson discovery only if WITH_CJSON=ON
When using cmake to build the project, cJson discovery
should only be performed if WITH_CJSON=ON.

Closes #2026.

Signed-off-by: Boris Feinstein <madhat1@gmail.com>
2021-01-17 16:16:54 +02:00
Roger A. Light
e2ebddfc54 Improve logging in obscure cases when a client disconnects.
Closes #2017. Thanks to Craig Leres.
2021-01-15 13:54:14 +00:00
Roger A. Light
9c4b9a0311 ctrl: Error if new passwords don't match.
Produce an error when requesting a new password if both
attempts do not match.

Closes #2011. Thanks to Willem Eradus.
2021-01-15 12:30:42 +00:00
Roger A. Light
26fbd0ec74 ctrl: Allow command line arguments to override config file options.
Closes #2010. Thanks to Willem Eradus.
2021-01-15 12:19:20 +00:00
Roger A. Light
300dc54dad Add notes that libsystemd-dev or similar is needed.
This is when building with systemd support on Linux.

Closes #2019. Thanks to Mark Symmes.
2021-01-15 09:58:19 +00:00
Roger A. Light
00083623f0 Fix websockets listeners with TLS not responding.
Closes #2020. Thanks to FozzTexx.
2021-01-15 09:53:45 +00:00
Roger A. Light
b8c6f26995 Fix message expiry interval property not being honoured for plugins.
This happened in `mosquitto_broker_publish` and
`mosquitto_broker_publish_copy` only.
2021-01-14 18:19:26 +00:00
Roger A. Light
4be32aefc6 Fix potential duplicate Will messages being sent.
This could have occurred when a will delay interval had been set.
2021-01-14 00:22:27 +00:00
Roger A. Light
18c98e7e07 Fix page slug. 2021-01-13 10:44:13 +00:00
Roger A. Light
9f9f92104b Add trivial basic authentication plugin based on IP. 2021-01-12 22:51:33 +00:00
Roger A. Light
695bbc33c8 Fix calculation of remaining length parameter for websockets clients.
Only affects those clients that send fragmented packets.

Closes #1974. Thanks to 贺亚东.
2021-01-12 10:22:04 +00:00
Roger A. Light
e78c04de9b Update docker hashes. 2021-01-11 16:53:35 +00:00
Roger A. Light
c55424e897 Merge branch 'fixes' 2021-01-11 16:48:10 +00:00
Roger A. Light
09a870c342 Better behaved lws external poll code. 2021-01-11 15:57:09 +00:00
Roger A. Light
5e6b34f81a Fix test. 2021-01-11 14:31:41 +00:00
Roger A. Light
5927778ae5 Improve logging in dynsec addGroupClient command.
Closes #2008. Thanks to Willem Eradus.
2021-01-11 13:28:20 +00:00
Roger A. Light
ae3800ad66 Bump version number, add www post. 2021-01-11 10:37:19 +00:00
Roger A. Light
d9a34fbb3a Improve documentation around the _v5() and non-v5 functions.
For example `mosquitto_publish()` and `mosquitto_publish_v5().
2021-01-11 10:05:34 +00:00
Roger Light
c4f4fae5a0 dynsec: Improve logging in addGroupRole.
Close #2005. Thanks to Willem Eradus.
2021-01-10 23:04:01 +00:00
Roger Light
4a114c6151 Remove unused struct member. 2021-01-09 21:24:30 +00:00
Roger A. Light
370cec5edd Fixes for lots of minor build warnings highlighted by Visual Studio. 2021-01-09 21:06:08 +00:00
Roger A. Light
e717b7f42c Merge branch 'Hallot-make-sure-xsltproc-installed' into fixes 2021-01-08 17:09:39 +00:00
Roger A. Light
f7255ac3cf Merge branch 'make-sure-xsltproc-installed' of git://github.com/Hallot/mosquitto into Hallot-make-sure-xsltproc-installed 2021-01-08 17:08:58 +00:00
Roger A. Light
6728c05a2c install Makefile target should depend on all, not mosquitto
This ensures that man pages are always built, even if a user runs `make
install` without building first.

Closes #1989. Thanks to woodz-.
2021-01-08 17:06:30 +00:00
Roger Light
7e1a818c54 Fix invalid behaviour in dynsec plugin.
This occurred if a group or client was deleted before a role that was
attached to the group or client is deleted.

Closes #1998. Thanks to Willem Eradus.
2021-01-08 00:01:10 +00:00
Roger Light
5b3acfe3cc Fix mosquitto_ctrl dynsec getGroup not showing roles.
Closes #1997. Thanks to Willem Eradus.
2021-01-07 23:36:56 +00:00
Roger Light
886ee6cd0c Fix bind_interface option.
Closes #1999. Thanks to Joerg55.
2021-01-07 22:50:32 +00:00
Roger Light
28c28fe707 Fix incorrect description in mosquitto_ctrl man page.
Closes #1995. Thanks to fyta2000.
2021-01-07 11:48:55 +00:00
Roger A. Light
70db9c486e Disallow control characters in mosquitto_passwd usernames. 2021-01-06 22:44:58 +00:00
Roger A. Light
93c730f799 Fix potential intermittent initial bridge connections when using poll(). 2021-01-06 22:03:34 +00:00
Roger A. Light
a69f125b80 No need to clear memory outside of condition. 2021-01-06 11:41:25 +00:00
Roger A. Light
86e0122a2d Only add/remove poll events when they aren't already done. 2021-01-06 11:41:00 +00:00
Roger A. Light
fabdfcc060 Further fix for large packets not being sent in a timely fashion. 2021-01-06 11:40:08 +00:00
Pierre Hallot
2cbb3e45ca
Look for xsltproc when needed; to fail early
Signed-off-by: Pierre Hallot <hallotpierre@gmail.com>
2021-01-04 16:53:51 +01:00
Roger Light
c604cf8fd0 net__write buf should be const. 2021-01-03 20:52:45 +00:00
Roger A. Light
491600ea7d codeql: Build cjson as a shared lib. 2020-12-30 21:42:07 +00:00
Roger A. Light
3ced609671 codeql: Build cJSON as Ubuntu bionic doesn't have it. 2020-12-30 13:34:13 +00:00