d0kuhn/mosquitto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,892 Commits 1 Branch 0 Tags 11 MiB
a16d7e0661
Commit Graph

1892 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Panagiotis Vasilikos
caeb211cc5 Memory leak in socks_mosq.c 
Reason: The memory allocated for the packet pointer at line 155 is not freed
before returning at line 188.

Fix: I inserted the mosquitto__free(packet) statement just before returning
at line 188.

Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
 2020-01-28 11:34:11 +01:00
Panagiotis Vasilikos
0f7052564c Memory leak in handle_unsubscribe.c 
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.

Fix: I moved the memory allocation code block (lines 69-73) just before
the line 102. This is the first place the pointer reason_codes is used, while
the following mosquitto__free operators free the allocated memory correctly.

Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
 2020-01-24 16:34:56 +01:00
Roger A. Light
4408339dbc Make consts unsigned where they are compared against unsigned. 2020-01-23 12:51:47 +00:00
Roger A. Light
5528dde56a Fix possible null dereferences. 2020-01-23 12:51:12 +00:00
Roger A. Light
05ec02b3f3 Remove dead values. 2020-01-23 10:55:49 +00:00
Roger A. Light
18f0508a6e Fix dereference before null check. 
Coverity Scan 1405815.
 2020-01-23 10:08:26 +00:00
Roger A. Light
db62f9843f Fix unused value being overwritten. 
Coverity Scan 1400727.
 2020-01-23 09:35:28 +00:00
Roger A. Light
6aa9b91fff Add testing target for compiling test client fixes. 2020-01-02 21:40:03 +00:00
Roger A. Light
d452ea138b Use presence of password file as indicator for authentication checks. 
Previously, authentication checks would only take place if usernames
were defined in the password file.

Closes #1545. Thanks to Timothy Godfrey.
 2019-12-20 00:19:17 +00:00
Roger A. Light
b6119bb759 Check ACL patterns for validity when loading. 
Closes #1539. Thanks to Leon Poon.
 2019-12-18 21:39:27 +00:00
Christian Schneider
a3ebeff9d7 fix: replace sleep with (p)select in loop_forever 
sleep was blocking loop_stop(force=false) since it
was uniteruptible

Signed-off-by: Christian Schneider <cschneider@radiodata.biz>
 2019-12-18 18:01:50 +01:00
Roger A. Light
adb6f3a39d Update Debian repo post to include up to date Debian dists. 2019-12-18 14:44:29 +00:00
Roger A. Light
c8789180f3 Fix session expiry with very large expiry intervals. 
Closes #1525. Thanks to Christoph Krey.
 2019-12-12 09:40:37 +00:00
Roger A. Light
6bfd52af9e Update Docker to 1.6.8. 2019-12-03 14:34:11 +00:00
Roger A. Light
70cc79a619 snap: mosquitto_rr needs priming. 2019-12-03 10:35:05 +00:00
Roger A. Light
ab6c7416b7 Update download links. 2019-12-03 10:07:12 +00:00
Roger A. Light
e55f7facce Merge branch 'fixes' 2019-11-28 17:14:53 +00:00
Roger A. Light
b410568299 Bump version, add release post. 2019-11-28 17:08:11 +00:00
Roger A. Light
b96739341d Update changelog for last pull request. 
Closes #1513.
 2019-11-28 16:41:35 +00:00
Roger Light
757e88e503
Merge pull request #1514 from basavesh/fixes 
In sub_client.c, call mosquitto_destroy() in cleanup label.
 2019-11-28 16:37:26 +00:00
Roger A. Light
6dec2b468b Remove redundant expiry checks 
This is all now handled in session_expiry.c, through session expiry interval/time.
 2019-11-28 16:19:57 +00:00
Roger A. Light
a46b45b006 Fix persistent_client_expiration not being used 
Closes #1494. Thanks to Christoph Krey.
 2019-11-28 16:17:41 +00:00
Basavesh Shivakumar
9bebab46ca In sub_client.c, call mosquitto_destroy() 
Fixes: #1513 and frees resources when someone terminates
via SIGTERM or SIGINT.

Signed-off-by: Basavesh Shivakumar <basavesh.shivakumar@gmail.com>
 2019-11-27 17:33:11 -05:00
Roger A. Light
c37251c53d Document mosquitto_connect_srv(). 
Closes #1499. Thanks to Basavesh Shivakumar.
 2019-11-22 11:16:53 +00:00
Roger A. Light
fc238895d1 Merge branch 'basavesh-master' into fixes 2019-11-21 14:22:36 +00:00
Roger A. Light
91961d93c4 Merge branch 'master' of git://github.com/basavesh/mosquitto into basavesh-master 2019-11-21 14:22:19 +00:00
Basavesh Shivakumar
7c34ed2eeb Delete duplicate 'Returns' messages in the comments. 
Signed-off-by: Basavesh Shivakumar <basavesh.shivakumar@gmail.com>
 2019-11-16 21:44:18 -05:00
Roger A. Light
a26157643d Add rr to snap. Add home plug to snap (not autoconnected). 2019-11-14 11:00:26 +00:00
Roger A. Light
3d92dcbbd9 Make documentation for mosquitto_pub -l match reality 
Blank lines are sent as empty messages.

Closes #1474. Thanks to majekw.
 2019-11-07 20:49:59 +00:00
Roger A. Light
1e04b22833 Fix mosquitto_pub -l not sending the final line of stdin 
This would happen if the final line did not end with a new line.

Closes #1473. Thanks to majekw.
 2019-11-07 18:25:56 +00:00
Roger A. Light
05171b266d Fix TLS Websockets clients not receiving messages. 
This can occurs after one client takes over a previous connection.

Closes #1489. Thanks to Bas Verhoeven.
 2019-11-06 22:25:33 +00:00
Roger Light
c052950639
Merge pull request #1328 from tgurr/cmake-pkgconfig 
Install pkg-config files into arch dependent locations also for CMake builds
 2019-11-06 15:34:21 +00:00
Roger A. Light
6bde209799 Added CLIENT_STATIC_LDADD to makefile builds 
This allow more libraries to be linked when compiling the clients with a
static libmosquitto, as required for e.g. openssl on some systems.

Closes #1371. Thanks to Fabrice Fontaine.
 2019-11-06 15:04:54 +00:00
Roger A. Light
eaab179933 Docker: Add ca-certificates to images. 2019-11-06 14:15:26 +00:00
Roger A. Light
678131e393 Docker - ca-certificates must not be installed in build-deps 2019-11-06 14:12:36 +00:00
Roger A. Light
28c11f4cce Fix tests where broker suddenly disconnects client 
This seems to be required just on more modern Python versions.
 2019-11-06 14:07:07 +00:00
Roger A. Light
aceabcdef2 Tidy up async test outputs. 2019-11-06 13:37:35 +00:00
Mario Vejlupek
cf1f4228a9 Add ca-certificates to Docker to support root certificates 
Signed-off-by: Mario Vejlupek <mario@vejlupek.cz>
 2019-11-06 13:31:01 +00:00
Roger A. Light
22eb193309 Merge branch 'stdin-fix-1' of git://github.com/majekw/mosquitto into majekw-stdin-fix-1 2019-11-06 13:24:38 +00:00
Roger A. Light
aabf850a62 Separate pub client loops for better readability. 2019-11-06 12:16:56 +00:00
Roger A. Light
74e1f77310 Fix for previous commit 
Stdin mode wouldn't work with normal compiler optimisation levels.
 2019-11-06 11:51:25 +00:00
Roger Light
4e7e6c641f
Merge pull request #1473 from majekw/stdin-rewrite 
mosquitto_pub: split main loop.
 2019-11-06 10:16:43 +00:00
Roger Light
25f458de74
Merge pull request #1487 from grom-42/fix-send-pkt 
Fix test on invalid null will topic value in connect packet

Fix test on invalid reserved bit value in connect packet

Add send of pubcomp in 02-subpub-qos2 script. To keep the broker session working while launching several tests on the same broker, the last packet of this transaction must be sent.

Fix way of sending packets in compliance tests. According to the documentation of python 3 socket::send method (https://docs.python.org/3/library/socket.html#socket.socket.send), the call to send must be retry until all data is sent while sending packet with a "large" amount of data.
 2019-11-06 09:49:15 +00:00
Jerome Malinge
fba1f6bc0a Fix test on invalid null will topic value in connect packet 
Signed-off-by: Jerome Malinge <gromgromm@yahoo.com>
 2019-11-04 15:58:00 +01:00
Jerome Malinge
11dc077d15 Fix test on invalid reserved bit value in connect packet 
Signed-off-by: Jerome Malinge <gromgromm@yahoo.com>
 2019-11-04 15:57:58 +01:00
Jerome Malinge
ce0b0d23d6 Add send of pubcomp in 02-subpub-qos2 script 
To keep the broker session working while launching several tests on
the same broker, the last packet of this transaction must be sent.

Signed-off-by: Jerome Malinge <gromgromm@yahoo.com>
 2019-11-04 15:57:55 +01:00
Jerome Malinge
d76e5fd199 Fix way of sending packets in compliance tests 
According to the documentation of python 3 socket::send method
(https://docs.python.org/3/library/socket.html#socket.socket.send),
the call to send must be retry until all data is sent while sending
packet with a "large" amount of data.

Signed-off-by: Jerome Malinge <gromgromm@yahoo.com>
 2019-11-04 15:57:38 +01:00
Roger A. Light
b622aaeee4 Fix messages with an expiry interval missing the property. 
They would be be sent without an expiry interval property just before
they were expired.

Closes #1464. Thanks to Dustin Sallings.
 2019-10-31 12:56:13 +00:00
Roger A. Light
06a27e799f Fix retained messages with an expiry interval not being expired. 
This happened after being restored from persistence.

Closes #1464. Thanks to Dustin Sallings.
 2019-10-31 12:54:20 +00:00
Roger A. Light
e6e7fc961d Fix function in wrong doc section. 2019-10-31 12:04:29 +00:00