Commit Graph

91 Commits

Author SHA1 Message Date
Roger A. Light
47ae6dd0e2 Fix mosquitto_passwd -U backup file creation.
Closes #2873.
2023-08-22 08:09:36 +01:00
Roger A. Light
3ab0a9a3fd mosquitto_ctrl dynsec init uses open( , O_EXCL | O_CREAT)
This allows us to refuse to open an existing file, without a race
condition.
2023-08-16 14:01:21 +01:00
Roger A. Light
44b94875b5 mosquitto_passwd uses mkstemp() for backup files. 2023-08-16 14:01:21 +01:00
Roger A. Light
4ca294fd9c Warn on lax permissions on sensitive files.
- Broker will log warnings if sensitive files are world readable/writable, or
  if the owner/group is not the same as the user/group the broker is running
  as. In future versions the broker will refuse to open these files.
2023-08-16 14:01:21 +01:00
Bart Desplanques
105e30ff5b Fix engine support.
Do not try to open keyfile when keyform is "engine": this is not necessarily a real file.
Dynamic engines require init with OPENSSL_INIT_ENGINE_DYNAMIC before they can be loaded.

Signed-off-by: Bart Desplanques <bart.desplanques@gmail.com>
2023-06-02 19:11:50 +02:00
Roger A. Light
28a39e62ff Remove unused header. 2023-03-07 14:16:27 +00:00
Roger A. Light
f9fa19ce6a - Fix -o not working in mosquitto_ctrl, and typo in related documentation.
Closes #2471. Thanks to Vitaljok and rillbert
2022-08-10 15:14:32 +01:00
Roger A. Light
3e1cf8a80b Fix tests build. 2022-05-25 16:16:48 +01:00
Roger A. Light
96931643a4 Use strings.h for strcasecmp, except on Windows.
Closes #2420. Thanks to Frédéric Fauberteau.
2022-02-24 12:02:16 +00:00
Roger A. Light
be80a3f4d0 Fix client id not showing in log on failed connections, where possible. 2021-10-06 10:09:38 +01:00
Roger A. Light
a1a190b482 Pointless whitespace tidy. 2021-10-05 15:20:37 +01:00
Roger A. Light
a73806acd4 App build fix. 2021-09-23 15:04:11 +01:00
Roger A. Light
77af2ecefe Fix mosquitto_ctrl dynsec setDefaultACLAccess command not working. 2021-08-30 22:28:51 +01:00
Roger A. Light
f952d19da1 Fix printf format build warning on MIPS.
Closes #2271. Thanks to Karl Palsson.
2021-08-24 13:58:15 +01:00
Roger Light
33349010cd Fix linker error 2021-08-22 07:55:10 +01:00
Roger Light
342aa0ad1a Fix installation using WITH_TLS=no.
Closes #2281. Thanks to Matt Turner.
2021-08-20 23:49:59 +01:00
Roger Light
e1c8f09372 Remove C++ style comments. 2021-04-25 22:26:12 +01:00
Roger A. Light
0446bba7df Fix some conversion warnings. 2021-04-19 09:37:20 +01:00
Roger A. Light
4ee03f21e3 Guard against missing UNUSED. 2021-03-29 17:07:40 +01:00
Roger A. Light
3ac2c3ee09 Improve mosquitto_ctrl documentation. 2021-03-26 10:42:18 +00:00
Roger Light
2de8c15bc9 Minor build fixes. 2021-03-21 09:18:43 +00:00
Roger A. Light
603107b87a Fix build of mosquitto_ctrl with static only libs. 2021-02-02 13:37:39 +00:00
Roger A. Light
706a1f3f29 Fix more minor compiler warnings. 2021-01-21 13:33:54 +00:00
Roger A. Light
a4389fc9ce Fix SPDX identifiers: EDL-1.0 -> BSD-3-Clause.
The two licenses are the same.
2021-01-20 11:46:18 +00:00
Roger A. Light
9c4b9a0311 ctrl: Error if new passwords don't match.
Produce an error when requesting a new password if both
attempts do not match.

Closes #2011. Thanks to Willem Eradus.
2021-01-15 12:30:42 +00:00
Roger A. Light
26fbd0ec74 ctrl: Allow command line arguments to override config file options.
Closes #2010. Thanks to Willem Eradus.
2021-01-15 12:19:20 +00:00
Roger A. Light
370cec5edd Fixes for lots of minor build warnings highlighted by Visual Studio. 2021-01-09 21:06:08 +00:00
Roger Light
5b3acfe3cc Fix mosquitto_ctrl dynsec getGroup not showing roles.
Closes #1997. Thanks to Willem Eradus.
2021-01-07 23:36:56 +00:00
Roger A. Light
70db9c486e Disallow control characters in mosquitto_passwd usernames. 2021-01-06 22:44:58 +00:00
Roger A. Light
fabdfcc060 Further fix for large packets not being sent in a timely fashion. 2021-01-06 11:40:08 +00:00
Roger Light
c604cf8fd0 net__write buf should be const. 2021-01-03 20:52:45 +00:00
Roger A. Light
b2da540c64 Fix large packets not being completely published to slow clients.
Also fix bridge connection not relinquishing POLLOUT after messages are
sent.

Closes #1977. Thanks to marchaesen.
Closes #1979. Thanks to GorazdKikelj.
2020-12-27 23:03:38 +00:00
Roger A. Light
99e8c8001d Build lib from in mosquitto_ctrl directory. 2020-12-17 15:19:12 +00:00
Roger Light
f63386bf4a Fix mosquitto_passwd -b using username as password.
Only applies if if `-c` is not also used.

Closes #1949. Thanks to J. Augusto de Oliveira.
2020-12-13 20:32:30 +00:00
Roger A. Light
f7dc138157 Fix install target when using WITH_CJSON=no.
Closes #1938. Thanks to apple3306 and JulianCaruso.
2020-12-11 00:07:11 +00:00
Roger A. Light
bdfa5e714a Fix mosquitto_passwd -U 2020-12-09 14:08:37 +00:00
Roger A. Light
791c63372b Fix cjson include paths. 2020-12-04 22:15:19 +00:00
Karl Palsson
58a06f3331 apps: mosquitto_ctrl: don't hard set paths
In a cross compile environment, these paths will be added elsewhere, and
in a local environment, they should already be covered by the system
compiler.  Simply drop them.

Signed-off-by: Karl Palsson <karlp@etactica.com>
2020-12-04 21:45:06 +00:00
Roger A. Light
6ad5f19aef CMake build fixes for Windows. 2020-12-03 14:02:17 +00:00
Roger A. Light
d6fe93aa51 ctrl: --force not supported. 2020-12-02 20:39:07 +00:00
Roger A. Light
26ffe1300a Various Windows build fixes. 2020-12-02 19:49:14 +00:00
Roger A. Light
550c54701e Fix cmake build when cjson not available. 2020-12-02 15:50:33 +00:00
Roger A. Light
d291effdcf Fix mosquitto_ctrl Makefile build yes/no based on deps. 2020-12-02 10:31:25 +00:00
Roger A. Light
3731535298 Add SPDX license identifiers. 2020-12-01 20:46:56 +00:00
Roger A. Light
757888b7f5 ctrl: Add warning if connecting without encryption. 2020-11-30 10:47:22 +00:00
Roger A. Light
584cf51ba7 Update to EPL-2.0 2020-11-25 17:34:21 +00:00
Roger A. Light
0713ad38b1 Silence Coverity Scan's concern over password_cmd derefencing.
This is a false positive, the conditions to trigger a NULL derefence
rely on argc changing value. However, this makes it impossible to go
wrong anyway.

Coverity Scan 1436868.
2020-11-25 11:04:58 +00:00
Roger A. Light
adfa9f1e21 Always zero terminate payloads (removes uhpa support) 2020-11-24 12:24:40 +00:00
Roger A. Light
0c6365726f Coverity Scan issues.
1436823
1436837
1436843
1432792
1436847
1436848
1436849
2020-11-24 10:06:28 +00:00
Roger A. Light
f83fcc8535 Fix Coverity Scan issues.
1436866
1436865
1436864
1436862
1436857
1436856
1436852
1436851
2020-11-24 00:47:30 +00:00