Roger A. Light
9d157f86ff
Fix for building on Windows with static lws.
2018-08-16 13:31:15 +01:00
Roger A. Light
14bd96e1e1
Add support for compiling with static libwebsockets library.
2018-08-16 11:28:26 +01:00
Roger A. Light
88765a5e80
Consistent use of config.h across the project.
2018-08-16 11:14:51 +01:00
Roger A. Light
0a4810286b
Check for 918
2018-08-15 17:41:14 +01:00
Roger A. Light
a199cac69e
Don't confuse expiring and duplicate clients.
2018-08-15 17:27:59 +01:00
Roger A. Light
ab5af8f0b9
Fix building for libwebsockets < 1.6.
2018-08-14 17:20:22 +01:00
Pierre Fersing
6fc7cadb63
Remove some test that was always true
...
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
2018-08-14 14:56:07 +01:00
Roger A. Light
af2678ea49
Fix possible endian issue when reading the memory_limit
option.
...
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-09 22:31:03 +01:00
Roger A. Light
945b3283a6
No need to calculate topic len twice.
2018-08-09 15:37:26 +01:00
Tatsuzo Osawa
cb56a75bbb
Fix subs memory issue #505
...
Signed-off-by: Tatsuzo Osawa <tatsuzo.osawa@gmail.com>
2018-08-09 15:25:52 +01:00
Roger A. Light
10b19a42ed
Fixes for building on NetBSD.
...
Closes #258 .
Thanks to Daniel Ölschlegel.
2018-08-09 15:21:40 +01:00
Roger A. Light
ecb4006f38
Don't reject ACL patterns without %u or %c, just warn.
...
Using `pattern blah/#` is a legitimate method of getting a global ACL.
We shouldn't be changing behaviour in a fixes release.
2018-08-09 14:32:02 +01:00
Natanael Copa
9e92cb0129
Flush stdout when asking for password.
...
Make sure the prompt is actaually printed by flushing stdout when asking
for passwords.
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
2018-08-09 13:47:11 +01:00
Tobias Assarsson
cc96485330
Add missing parameters to internal mosquitto_acl_check
...
Signed-off-by: Tobias Assarsson <tobias.assarsson@gmail.com>
2018-08-09 13:05:35 +01:00
Roger A. Light
7c94a73c17
Fix UNSUBACK messages not being logged.
...
Closes #903 .
Thanks to Christoph Krey.
2018-08-09 11:54:24 +01:00
Roger A. Light
0d25cb58b4
Fix use_identity_as_username true
not working.
...
Closes #833 .
Thanks to David Crook and Brice Waegeneire.
Bug: https://github.com/eclipse/mosquitto/issues/833
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-08 15:36:42 +01:00
bricewge
2a3305a4a2
fix #833
...
Signed-off-by: Brice Waegeneire <brice.wge@gmail.com>
2018-08-08 15:27:05 +01:00
Roger A. Light
e185d18917
Better fix for #851 .
...
Ensure all sockets that are closed are set to INVALID_SOCKET.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-08 15:23:03 +01:00
Wolfgang Hottgenroth
88456c655f
Move check whether context is a bridge in front of check whether a listener
...
exists for context. New test now passes.
Signed-off-by: Wolfgang Hottgenroth <wolfgang.hottgenroth@icloud.com>
2018-08-08 13:42:50 +01:00
Roger A. Light
39170d1181
ACL patterns that do not contain either %c or %u are now rejected.
...
Closes #209 .
Bug: https://github.com/eclipse/mosquitto/issues/209
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-08 13:15:54 +01:00
Pierre Fersing
abaceb9c9e
Fix missing rename of mosquitto__socket_get_address
...
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
2018-08-02 21:32:08 +01:00
Roger A. Light
2f6f5dbf9d
Fix problem on Pi caused by unsigned char being default.
...
Found via #849 .
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 21:06:47 +01:00
Roger A. Light
fc9a0db966
All clients now time out if they exceed their keepalive*1.5
...
This was inconsistent before.
Partially addresses #865 .
2018-08-02 13:05:36 +01:00
Roger A. Light
b07e0c08bf
Fix IPv6 addresses not being able to be used as bridge addresses.
...
Closes #886 .
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 13:01:02 +01:00
Roger A. Light
bcf76b9cb6
Remove use of AI_ADDRCONFIG.
...
Closes #869 , #901 .
Thanks to Alex Richman.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 01:11:31 +01:00
Roger A. Light
286400abcf
Use AF_UNSPEC etc. instead of PF_UNSPEC to comply with POSIX.
...
Closes #863 .
Thanks to denigmus and Patrick TJ McPhee.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 00:27:52 +01:00
Roger A. Light
a954081673
Print more OpenSSL errors when loading certificates/keys fail.
...
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-01 21:24:02 +01:00
Dave Miller
81a82f6fe2
Fix for issue #874
...
With special acknowledgement to sxsing (his github login) for his
help in development and testing of this fix.
NOTE: Pull-request is against master as the fixes branch has not
been updated with the v1.5 file src/handle_connect.c
Signed-off-by: Dave Miller <dmiller@tibco.com>
2018-08-01 19:30:40 +01:00
Roger A. Light
8bbb5887d0
[Broker] Fix auth plugin cleanup function not being called.
...
Closes #900 .
Thanks to Julian Zhao.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-01 15:53:29 +01:00
Roger A. Light
5e60136449
Merge branch 'develop'
2018-05-03 07:55:45 +01:00
Roger A. Light
e9d03c8ffd
Merge branch 'fixes'
2018-05-02 22:33:27 +01:00
Roger A. Light
e90a32835b
Merge branch 'fixes' into develop
2018-05-02 22:24:49 +01:00
Roger A. Light
1a913bddd9
Fix realpath() usage for nonexistant files.
2018-05-02 21:21:07 +01:00
Roger A. Light
377dc82d3f
Fix parsing of configuration options that end with a space.
...
Closes #804 .
Thanks to Nicola Lunghi.
2018-05-02 21:04:46 +01:00
Roger A. Light
6c7ecd7e97
Fix compiling without TLS.
2018-05-02 21:04:42 +01:00
Roger A. Light
51ec5601c2
Fix memory leak that could be caused by a malicious CONNECT packet.
...
Closes #533493 (on Eclipse bugtracker)
Thanks to Daniel Romero.
2018-05-02 21:04:39 +01:00
Roger A. Light
cec1af1386
Don't print uninteresting epoll warnings.
2018-05-02 17:33:33 +01:00
Roger A. Light
5b4a4cfc6a
Fix compilation warnings around _BSD_SOURCE.
2018-05-02 09:39:36 +01:00
Roger A. Light
2d1667b120
Remove c99-isms due to problems with dependencies.
2018-05-02 09:32:37 +01:00
Roger A. Light
23230b7b18
Add per-listener acl handling.
2018-05-01 22:54:25 +01:00
Roger A. Light
62d99ecbc2
Build fixes.
2018-04-23 23:56:39 +01:00
Roger A. Light
caa9e46fda
Fix bad merge.
2018-04-19 20:38:10 +01:00
Roger A. Light
57ee8b92bc
Mac build fixes.
2018-04-16 11:48:42 +01:00
Roger A. Light
7bf16919f3
Validate config strings as UTF-8.
2018-04-13 14:53:10 +01:00
Eric Schneeberger
e4e6a67959
Increase maximum connections (Windows) from 512 to 2048 (Maximum)
...
Signed-off-by: Eric Schneeberger <eric.schneeberger@gtt.com>
2018-04-13 12:10:45 +01:00
Roger A. Light
7615ae24ce
Handle CONNECT protocol errors.
...
Don't allow username when no username flag set.
Don't allow password when no password flag set.
Closes #730 . Closes #731 .
Thanks to Umberto Boscolo.
2018-04-12 22:53:49 +01:00
Roger A. Light
729a09310a
Add UTF-8 tests, plus some validation fixes.
...
Closes #693 .
2018-04-12 22:20:10 +01:00
Roger A. Light
6a2172f472
Windows fixes.
2018-04-12 11:09:02 +01:00
Roger A. Light
f4c9435f54
Use server methods in the broker.
2018-04-12 10:24:03 +01:00
hailinzeng
a6aa3bc5f9
remove dead code
...
Signed-off-by: hailinzeng <hailinzeng@gmail.com>
2018-04-11 23:44:33 +01:00
Roger A. Light
5ff8127f44
Fix will sending for duplicate clients.
...
When a client with an in-use client-id connects, if the old client has a
will, send the will message. Closes #26 .
Thanks to Pierre F.
2018-04-11 23:17:17 +01:00
Roger A. Light
943b311344
Don't use deprecated openssl functions.
2018-04-11 22:10:48 +01:00
Roger A. Light
a5781c0b46
Missing #endif.
2018-04-11 21:13:18 +01:00
Roger A. Light
24d68b5af8
Remove support for openssl 1.0.0 and 1.0.1.
...
These are no longer supported by openssl.
2018-04-11 17:12:25 +01:00
Roger A. Light
f4d238be18
Bump copyright years.
2018-04-11 15:24:29 +01:00
Roger A. Light
d982c265cb
Fix signed/unsigned comparison.
...
Closes #747 , closes #753 .
2018-04-09 22:59:15 +01:00
Tifaifai Maupiti
f2376551bc
Fix: use websockets without OpenSSL / TLS.
...
Signed-off-by: Tifaifai Maupiti <tifaifai.maupiti@gmail.com>
2018-04-09 21:29:22 +01:00
Roger A. Light
40e6a75709
Use c99 as compiling standard.
...
Closes : #765 .
2018-04-06 00:33:22 +01:00
Roger A. Light
c3314fd593
Add missing tests ( Closes #748 ).
2018-04-05 23:57:03 +01:00
Roger A. Light
2a05602d84
Obtain canonical name for password file.
2018-03-27 07:33:48 +01:00
Roger A. Light
d09d7c47c5
Further Coverity Scan fixes.
2018-03-27 00:06:39 +01:00
Roger A. Light
dbdd113c86
Merge branch 'develop' of github.com:eclipse/mosquitto into develop
2018-03-26 22:57:32 +01:00
Roger A. Light
e273c2593e
Fix uninitialised variable.
2018-03-26 22:50:41 +01:00
Roger A. Light
8a22b918c0
Fix Coverity Scan defects.
2018-03-26 22:47:46 +01:00
Roger A. Light
a979ed6535
Per listener plugins.
2018-03-26 15:23:00 +01:00
Roger A. Light
a3b859a995
Remove name confusion
2018-03-25 21:49:14 +01:00
Roger A. Light
600217649b
Merge branch 'develop' of github.com:eclipse/mosquitto into develop
2018-03-23 10:36:57 +00:00
Roger A. Light
13753f7661
Fix building mosquitto_passwd on Windows.
2018-03-23 10:35:50 +00:00
Roger A. Light
26bc3206cd
Per listener allow_zero_length_clientid.
2018-03-18 21:23:50 +00:00
Roger A. Light
7271893966
Per listener auto_id_prefix.
2018-03-18 21:08:39 +00:00
Roger A. Light
4e266ff28f
Copy default parameters.
2018-03-15 22:03:17 +00:00
Roger A. Light
fd7b08c0eb
Per listener psk_file.
2018-03-15 21:39:42 +00:00
Roger A. Light
b2e1592376
Per listener allow_anonymous.
2018-03-15 14:29:07 +00:00
Roger A. Light
7046691b7d
Reload password files properly.
2018-03-15 14:29:02 +00:00
Roger A. Light
aa87f3c170
Per listener allow_anonymous.
2018-03-15 12:18:19 +00:00
Roger A. Light
a571104809
Check correct password list.
2018-03-15 11:08:19 +00:00
Roger A. Light
0fef6bdee8
Maximum connections on Windows increased to 2048.
...
Thanks to ericGTT.
2018-03-14 10:01:47 +00:00
Peter Korsgaard
01ead7e73e
websockets.c: unbreak build without TLS
...
Commit 7943072b1f
(Fix use_identity_as_username not working on websockets
clients) added code which unconditionally accesses mosq-ssl, breaking the
build when TLS support is disabled.
Fix it by guarding this logic inside #ifdef WITH_TLS.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-13 23:16:25 +00:00
Roger A. Light
57e852db05
Per listener password file.
2018-03-13 17:52:04 +00:00
Roger A. Light
bc13eab9d6
Add per_listener_settings, which isn't used yet.
2018-03-13 17:52:03 +00:00
Roger A. Light
4d3f5b2b39
Ensure pollfd_index is initialised.
2018-03-13 17:52:03 +00:00
Thomas Pedley
ba8734b749
Add LWT message logging.
...
Signed-off-by: Thomas Pedley <me@shallax.com>
2018-03-13 13:41:58 +00:00
Roger A. Light
9ea0d38002
[706] Serve http /dir/ as /dir/index.html.
...
Thanks to Jean-Claude Wippler.
2018-03-13 09:12:54 +00:00
Roger A. Light
4f838e5161
Windows fixes.
2018-02-28 15:53:24 +00:00
Roger A. Light
5b2bf3d1c1
Bump version number, update copyrights.
2018-02-28 11:15:20 +00:00
Roger A. Light
e6cbff0e94
Fix unauthorised clients being able to cause OOM on connect.
2018-02-24 22:09:19 +00:00
Roger A. Light
b76982db13
Fix reloading of config when fds are exhausted.
2018-02-24 21:44:38 +00:00
Roger A. Light
ec63d7bfc7
Add set_tcp_nodelay option to disable Nagle's algorithm.
...
Bug: https://github.com/eclipse/mosquitto/issues/433
2018-02-14 23:51:16 +00:00
Roger A. Light
81cb7ab547
Merge branch 'fixes' into develop
2018-02-13 14:16:47 +00:00
Roger A. Light
c001e778c1
[693] Fix handling of null bytes in received strings.
...
Thanks to Umberto Boscolo.
Bug: https://github.com/eclipse/mosquitto/issues/693
2018-02-13 12:19:34 +00:00
Roger A. Light
3066f89a24
packet__read_string() returns the string length.
2018-02-11 20:47:17 +00:00
Roger A. Light
ff55499725
Fix persistence reloading.
2018-01-13 21:11:07 +00:00
Roger A. Light
027c5d7f6e
Don't remove invalid socket from epoll fd.
2018-01-13 21:10:24 +00:00
Roger A. Light
2283585e39
Remove build timestamp information for reproducible builds.
2018-01-12 13:41:09 +00:00
Pierre Fersing
59380cef2d
Fix CONNACK not send over WebSocket for bad auth
...
When client over WebSockets fail to authenticate, the CONNACK packet was
not sent because the connection was closed too early. Closes #18 .
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
2018-01-12 13:34:12 +00:00
Roger A. Light
b4c72e8fc0
Fix HUP disconnecting clients incorrectly.
...
Bug: https://github.com/eclipse/mosquitto/issues/657
2018-01-10 22:34:03 +00:00
Roger A. Light
9c6a5f3cf0
[656] Fix building on Windows.
...
Thanks to Arun Kirthi Cherian.
Bug: https://github.com/eclipse/mosquitto/issues/656
2018-01-06 22:42:40 +00:00
Tatsuzo Osawa
024fd400d4
Fix Unsubscribe with No Topic
...
Signed-off-by: Tatsuzo Osawa <tatsuzo.osawa@gmail.com>
2018-01-06 12:11:06 +00:00
Pierre Fersing
7775924bae
[534]Fix upgrade_outgoing_qos for retained message
2018-01-03 18:50:34 +01:00
Pierre Fersing
7df5c40004
Fix $SYS counters when message is sent over WS
...
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
2018-01-02 16:51:56 +01:00