d0kuhn/mosquitto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
637 Commits 1 Branch 0 Tags 11 MiB
74adb43cc1
Commit Graph

323 Commits

Author SHA1 Message Date
Roger A. Light
1cd40925b8 [184] Don't attempt to install docs when WITH_DOCS=no. 
Thanks to minghuadev.

Bug: https://github.com/eclipse/mosquitto/issues/184
 2016-06-06 16:11:42 +01:00
Roger A. Light
63416e6547 ; 2016-06-06 16:03:24 +01:00
Roger A. Light
5d96c3d7ba [186] Fix TLS operation with websockets listeners and libwebsockts 2.x. 
Bug: https://github.com/eclipse/mosquitto/issues/186
 2016-06-06 15:53:05 +01:00
Roger A. Light
ea2baa876c Fix rare possible crash when writing persistence file. 2016-05-31 22:17:27 +01:00
Roger A. Light
ff78cd7873 Fix publishing of $SYS/broker/clients/maximum. 2016-05-31 09:57:28 +01:00
Roger A. Light
6f5f445196 [169] mosquitto_passwd handles unknown cmd args properly. 
Closes #169. Thanks to castorgodinho.

Bug: https://github.com/eclipse/mosquitto/issues/169
 2016-05-26 09:25:41 +01:00
Roger A. Light
7761218d3c [170] Fix WS listeners not being able to bind to an IP. 
Closes #170. Thanks to minghuadev.

Bug: https://github.com/eclipse/mosquitto/issues/170
 2016-05-26 09:21:15 +01:00
Roger A. Light
afc2c9951c [57] File missed from previous commit. 
Bug: https://github.com/eclipse/mosquitto/issues/57
 2016-05-19 15:53:27 +01:00
Roger A. Light
57da586703 Fix saving of persistence messages that start with a '/'. 
Closes #151. Thanks to Andrew Chambers.

Signed-off-by: Roger A. Light <roger@atchoo.org>
 2016-05-14 22:39:14 +01:00
Roger A. Light
3048c5ba0d Changelog update. 
Fix reconnecting for bridges that use TLS on Windows.

Closes #154.

Thanks to Dmitry Kaukov.
 2016-05-14 21:57:09 +01:00
Roger A. Light
6704df8061 Bridge config parameters can now contain a space 
Closes #150.

Thanks to Sebastian Koch and Mikkel Kirkgaard Nielsen.

Bug: https://github.com/eclipse/mosquitto/issues/150
 2016-04-28 21:54:50 +01:00
Frank Busse
10bb523854 fix 16 byte memory leak 
Adds missing free for config->pid_file in mqtt3_config_cleanup.

Signed-off-by: Frank Busse <bb0xfb@gmail.com>
 2016-03-24 13:34:39 +01:00
Frank Busse
defbfbd185 DOS: use-after-free in ACL message handling 
Removing the last message in queue because of an ACL leaves last_msg
in a corrupted state. Therefore an unauthorized attacker may cause a
segfault of the broker.

Signed-off-by: Frank Busse <bb0xfb@gmail.com>
 2016-03-24 13:19:45 +01:00
Roger A. Light
69a08ab905 Fix string quoting in CMakeLists.txt. Closes #4. 2016-03-13 20:33:08 +00:00
Roger A. Light
fda0cb3d45 Fix incorrect $SYS heap memory reporting when using ACLs. 2016-03-12 13:25:20 +00:00
Roger A. Light
abc2f3f9de Network errors are printed correctly on Windows. 2016-03-07 20:57:22 +00:00
Roger A. Light
a79412e3d8 Fix compile error from library keepalive handling. 2016-03-06 19:49:20 +00:00
Roger A. Light
1065a0f202 Will topic isn't truncated when using a mount_point. 2016-03-05 22:38:05 +00:00
Roger A. Light
6bac3f072c Reconnecting client doesn't start with mid=1 again. 2016-03-05 22:34:05 +00:00
Roger A. Light
d9142c3974 [476314] Deliver queued WS client msgs on reconnect. 
Thanks to Joking Young and Christoph Krey.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=476314
 2016-03-05 22:31:52 +00:00
Roger A. Light
af995d211d Fix client library keepalive handling. 
Fix the case where a message received just before the keepalive timer
expired would cause the client to miss the keepalive timer.

Thanks to Graham Benton.
 2016-02-28 17:24:43 +00:00
Roger A. Light
f588075931 [485589] Close stdin etc. when daemonised. 
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=485589
 2016-02-11 21:49:55 +00:00
Roger A. Light
eb514c9707 [487178] Obey mount_point when publishing wills. 
Wills published by clients connected to a listener with mount_point defined
now correctly obey the mount point. This was a potential security risk
because it allowed clients to publish messages outside of their restricted
mount point. This is only affects brokers where the mount_point option is in
use.

Thanks to Lance Riley.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=487178
 2016-02-11 21:17:55 +00:00
Roger A. Light
af96c0b8fa [485143] Futher fix for broken win32 connections. 2016-01-19 14:05:39 +00:00
Roger A. Light
00491da031 [485143] Fix detection of broken connections on Windows. 
Thanks to Pierre-Yves Boisbunon.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=485143
 2016-01-14 21:15:02 +00:00
Roger A. Light
51f275bd02 Error messages for websockets init failure. 2016-01-07 21:56:16 +00:00
Roger A. Light
2549919413 Fix support for libwebsockets 1.22. 2015-12-21 11:32:02 +00:00
Roger A. Light
7aa653c42f Add support for libwebsockets 1.6. 2015-12-19 01:21:17 +00:00
Roger A. Light
80300f8fa1 [468987] Free unused topic tree elements. 
Fix in 1.4.3 was incomplete.

Thanks to Guido Hinderberger et al.
 2015-11-08 20:23:07 +00:00
Roger A. Light
26eac3c1ca Fix possible memory leak with bridges and SSL. 
Fix possible memory leak if bridge using SSL attempts to connect to a
host that is not up.

Thanks to Ed Morris.
 2015-10-12 14:48:52 +01:00
Roger A. Light
011de7ed19 Fix excessive calls to message retry check. 2015-09-16 22:14:26 +01:00
Roger A. Light
2597da17c2 [475807] Fix cross compiling of websockets. 
Thanks to Tyler Brandon.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=475807
 2015-09-16 21:13:03 +01:00
Roger A. Light
0c0961f6a4 [477571] Fix socket leak with bridges. 
Don't leak sockets when an outgoing bridge connection with multiple
addresses is rejected.

Thanks to Johnny Egeland.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=477571
 2015-09-16 17:39:00 +01:00
Roger A. Light
201bb1a04a Fix potential crash on libwebsockets error. 2015-08-18 23:33:55 +01:00
Roger A. Light
2172ffb56c [470253] Fix potential memory leaks. 
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=470253
Also-by: Wun Yu <wuyun1984_1984@163.com>
 2015-08-17 22:10:26 +01:00
Roger A. Light
ab7f212b7e [468987] Free unused topic elements. 
Reduces memory usage and CPU usage.

Thanks to Guido Hinderberger, Martin Rauscher and Michael Hekel.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=468987
 2015-08-17 21:25:30 +01:00
Anmol Sarma
13d869b8df Avoid calls to strlen() when checking for empty strings. 
Change-Id: I3de322006623483cbf20218da071a9da5d7b2e2b
Signed-off-by: Anmol Sarma <me@anmolsarma.in>
 2015-08-17 16:00:16 -04:00
Roger A. Light
e49e398eb3 Fix handling of outgoing QoS>0 messages for bridges. 
Fix handling of outgoing QoS>0 messages for bridges that could not be
sent because the bridge connection was down.
 2015-08-17 20:50:41 +01:00
Anmol Sarma
343e833fd9 Remove superfluous branch. 
Signed-off-by: Anmol Sarma <me@anmolsarma.in>
 2015-08-10 09:33:05 -04:00
Roger A. Light
e0037b348f [465438] Fix incorrect behaviour for autosave_interval. 
Thanks to Jaime Yu.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=465438
 2015-06-29 17:11:16 +01:00
Roger A. Light
dc5abcac95 [470660] Handle fragmented TLS packets without a delay. 
Thanks to Martin Rauscher.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=470660
 2015-06-25 10:53:24 +01:00
Roger A. Light
0733b3f68b Fix use of sprintf. 2015-05-21 17:15:10 +01:00
Roger A. Light
cdb1cf9b13 Remove typos. 2015-05-17 07:31:54 +01:00
Roger A. Light
15b291eaa4 Remove unsigned comparison against <0. 
Coverity CID 1292471.
 2015-05-17 07:04:41 +01:00
Roger A. Light
a6827df6c0 [467096] Fix incorrect bridge notification. 
If a custom notification topic was used, the bridge status would be set
to 1 before a connection was attempted, this has been fixed.

Initial updates to the status topic are now only set once, when the
broker starts, rather than each time the bridge attempts to reconnect.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=467096
 2015-05-16 12:05:17 +01:00
Roger A. Light
6f2fe06f0b [464811] Fix handling of payload lengths>4096 with websockets. 
Thanks to Arjen van Elteren and Stephen Zeng.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=464811
 2015-05-06 16:40:10 -05:00
Roger A. Light
121c2ca002 Broker will return CONNACK rc=5 when a client is not authorised. 
This was being incorrectly set as rc=4.
 2015-05-06 04:54:11 -05:00
Roger A. Light
ec2fcce43b Don't send websockets messages if the message is queued. 2015-04-29 10:16:59 +01:00
Roger A. Light
11d0d887f0 Fix parsing of auth_opt_ arguments with extra spaces/tabs. 2015-04-24 20:57:30 +01:00
Roger A. Light
cc7beb62a5 [465384] Fix crash on Windows when using bridges. 
Thanks to Stefan Rosskopf.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=465384
 2015-04-24 09:34:24 +01:00
Roger A. Light
21b372ed9e ACLs are now checked before sending a will message. 2015-04-18 22:16:57 +01:00
Roger A. Light
991f1173d7 Fix persistent db writing on Windows. 
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=464779
 2015-04-17 21:51:24 +01:00
Roger A. Light
1bdd6c36a8 Fix incorrect bridge connection notifications on local broker. 2015-04-17 21:51:21 +01:00
Roger A. Light
960b3ef32d Fix possible minor memory leak on acl parsing. 2015-03-30 22:26:44 +01:00
Roger A. Light
dacee786be [463000] Use own type to simplify socket handling. 
Means that SOCKET is used as the socket type everywhere on Windows.
 2015-03-29 10:43:08 +01:00
Roger A. Light
7cd14725da Fix compiler warning. 2015-03-28 15:16:15 +00:00
Roger A. Light
502c3e7563 [461619] Disconnect idle websockets clients. 
Websockets clients are now periodically disconnected if they have not
maintained their keepalive timer.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=461619
 2015-03-27 20:50:16 +00:00
Roger A. Light
35b729909c [463241] Fix possible crash under heavy network load. 
Thanks to Alexandre Zia.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=463241
 2015-03-27 01:07:48 +00:00
Roger A. Light
ccc8a81187 Ignore multiple spaces when parsing acl files. 2015-03-26 22:37:01 +00:00
Roger A. Light
c6450ac265 [462154] Fix problems parsing config strings with leading spaces. 
Thanks to Aidan Gill.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=462154
 2015-03-15 20:49:18 +00:00
Roger A. Light
28404350c4 Fix possible crash when using pattern ACLs. 2015-03-08 21:00:15 +00:00
Roger A. Light
3a36ae843b Fix lws 1.3 detection. 2015-02-23 15:20:23 +00:00
Roger A. Light
fcf91f9cd9 Fix compiling on Linux with CMake. 2015-02-22 12:20:29 +00:00
Roger A. Light
279b67bf8d Minor packaging related fixes. 2015-02-18 01:34:43 +00:00
Roger A. Light
f04c10e609 Fix incorrectly committed change. 2015-02-17 23:23:13 +00:00
Roger A. Light
ff3ebd969b Fix building on OS X. 2015-02-17 23:21:14 +00:00
Roger A. Light
ff9c2087b1 Basic support for libwebsockets 1.2.x. 2015-02-16 22:02:34 +00:00
Roger A. Light
2098d6a392 Remove debug line. 2015-02-15 20:10:46 +00:00
Roger A. Light
91c1972c1f Consistent error message. 2015-02-14 13:08:49 +00:00
Roger A. Light
db86809ee9 Add websockets logging options. 2015-02-13 22:57:49 +00:00
Roger A. Light
6fd38b8c47 Windows fixes. 2015-02-13 21:18:52 +00:00
Roger A. Light
3ed5c94038 Struct optimisations. 2015-02-13 21:17:11 +00:00
Roger A. Light
8b1560def0 Parse config strings as entire line. 2015-02-12 22:48:28 +00:00
Roger A. Light
f781498c03 Ensure that file logging uses the correct username. 2015-02-08 22:06:11 +00:00
Roger A. Light
626857b20a Close and reopen log_dest file on HUP. 2015-02-05 22:44:38 +00:00
Roger A. Light
c276fd9572 When using "log_dest file" the output file is now flushed periodically. 2015-02-05 22:29:49 +00:00
Roger A. Light
22e09ae613 [455402] Fix potential hang with pattern acls. 
Fix hang if pattern acl contains a %u but an anonymous client connect.

Thanks to Christoph Krey.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=455402
 2015-01-27 23:33:36 +00:00
Roger A. Light
45b8220a82 [458690] Fix build for WITH_BRIDGE=no 
Thanks to Alexandre Zia.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=458690
 2015-01-27 23:33:36 +00:00
Roger A. Light
8eda59c1d9 [452927] Fix bind()/listen() error reporting on Windows. 
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452927
 2015-01-28 20:56:51 +00:00
Roger A. Light
1b4903b41e [431780] ACL files can contain a space in username/topic. 
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=431780
 2015-01-27 23:33:36 +00:00
Roger A. Light
153e6e6211 [452914] Drop root privileges after listeners started. 
This means that TLS private keys can be restricted to the root user.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452914
 2015-01-27 23:33:36 +00:00
Roger A. Light
87d8e1f705 Bridge support for MQTT v3.1.1. 2015-01-27 17:12:36 +00:00
Roger A. Light
34176359c9 [452913] Prevent dereferencing of NULL string. 
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452913
 2015-01-26 21:02:53 +00:00
Roger A. Light
96d98e620b Fix compiling on Apple. 2015-01-24 22:18:28 +00:00
Roger A. Light
0adb2ed217 [425835] Support for "hour client expiration times. 
This allows shorter values for the persistent_client_expiration option.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=425835
 2015-01-15 21:57:03 +00:00
Roger A. Light
aca979a473 [457371] Fix building for WITH_TLS=no 
Thanks to Micheal Laing.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=457371
 2015-01-15 20:11:14 +00:00
Roger A. Light
8a18f577a6 Remove more unnecessary uses of calloc. 2015-01-14 21:56:57 +00:00
Roger A. Light
97849e8825 Remove unnecessary uses of calloc. 2015-01-14 21:43:39 +00:00
Roger A. Light
cfe1156eb7 Reference count store structs when reloading from db. 
Without this increment, a message could be incorrectly freed in rare
circumstances.
 2015-01-08 18:41:14 +00:00
Roger A. Light
b52e3311d2 Disconnect websockets clients properly. 
context->state was being overwritten when websockets clients
attempted to disconnect, leaving them in limbo. This has been fixed.

Thanks to FeelyChau.
 2015-01-07 23:33:31 +00:00
Roger A. Light
faaf3edd02 Fix library linking with CMake. 
When using CMake it wasn't possible to use libwrap due to a
configuration error. This has been fixed.

Thanks to Markus Rathgeb.
 2015-01-07 22:18:39 +00:00
Roger A. Light
175794826b [456899] Broker: Add bridge_attempt_unsubscribe option. 
The bridge_attempt_unsubscribe option has been added, to allow the sending
of UNSUBSCRIBE requests to be disabled for topics with "out" direction.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=456899
 2015-01-07 21:50:10 +00:00
Roger A. Light
778bd4ca25 Clear store variable correctly here. 2015-01-06 17:37:56 +00:00
Roger A. Light
0e72d3cc32 Should check acl result for lack of success, not presence of error. 2015-01-06 17:35:46 +00:00
Roger A. Light
f8f794c531 Allow expiring clients to be cleaned up. 2015-01-06 17:35:12 +00:00
Roger A. Light
b30adbf792 Remove incorrectly committed file. 2015-01-06 11:25:25 +00:00
Roger A. Light
fb588ef434 Print dlerror on library loading errors. 2014-11-20 22:33:40 +00:00
Roger A. Light
85a294922e Protect stored messages from removal when queing. 2014-11-20 21:13:21 +00:00
Roger A. Light
5b6f6976c7 Fix use of "dup" with pubrel, subscribe, unsubscribe. 
Thanks to Paolo Patierno.
 2014-11-19 21:28:52 +00:00
Roger A. Light
2ce4d94282 Fix dereferencing of msg store items. 2014-11-19 20:59:10 +00:00