Roger A. Light
f64d3b1e5c
Fix broker originated messages not being sent.
...
This occurred when `check_retain_source` was set to true.
Closes #1245 . Thanks to Christoph Krey.
2019-04-30 13:25:54 +01:00
Roger A. Light
a9f17cea95
Fix Will message not allowing user-property properties.
2019-04-30 13:25:27 +01:00
Roger A. Light
203949a512
Fix -L url parsing.
...
Closes #1248 . Thanks to Andrew J Freyer.
2019-04-30 13:24:33 +01:00
Roger A. Light
dc4b823f92
Fix crash after client has been unable to connect to a broker
...
This is part of the cleanup routine when the client is already exiting.
Closes #1246 . Thanks to Christoph Krey.
2019-04-30 13:23:25 +01:00
Roger A. Light
eebdbc86c4
Fix access after free when v5 client with Will message disconnects.
...
The Will message has as its first property one of content-type,
correlation-data, payload-format-indicator, or response-topic.
Closes #1244 . Thanks to Christoph Krey.
2019-04-30 13:21:05 +01:00
Roger A. Light
42fb2f5538
Fix build for WITH_TLS=no.
...
Closes #1250 . Thanks to bmparr.
2019-04-29 22:56:22 +01:00
Roger A. Light
35793ca1c4
Bump version number, update webpage.
2019-04-26 17:07:09 +01:00
Roger A. Light
439575475c
Use CMAKE_INSTALL_* variables when installing in CMake.
...
Closes #1049 . Thanks to Greg Troxel.
2019-04-26 17:07:05 +01:00
Roger A. Light
efa649f451
Don't call ldconfig in CMake scripts.
...
Closes #1048 . Thanks to Greg Troxel.
2019-04-26 17:07:02 +01:00
Roger A. Light
3b4a5419c3
Build fixes around CFLAGS et al.
...
- Split CFLAGS and CPPFLAGS, and LDFLAGS and LDADD/LIBADD.
- test/unit now respects CPPFLAGS and LDFLAGS.
Closes #1232 . Thanks to Greg Troxel.
2019-04-26 17:06:54 +01:00
Roger A. Light
0d01e212ad
Document bundled dependencies and how to disable.
...
Closes #1231 . Thanks to Greg Troxel.
2019-04-26 16:25:43 +01:00
Roger A. Light
d6c7923d16
Add make check
and document testing procedure.
...
Also support test target in cmake.
2019-04-26 16:25:35 +01:00
Roger A. Light
27b8bcf320
Document memory_limit
option.
2019-04-26 11:48:29 +01:00
Roger A. Light
5c0c830229
Fix compilation on musl C systems due to missing sys/time.h header.
...
Thanks to maxice8.
2019-04-25 21:22:51 +01:00
Roger A. Light
449103e960
Merge remote-tracking branch 'refs/remotes/origin/fixes'
...
Conflicts:
ChangeLog.txt
2019-04-17 17:51:34 +01:00
Roger A. Light
56757df512
Bump version and changelog details.
2019-04-17 17:44:02 +01:00
Roger A. Light
fb1979c0ea
Fix build on SmartOS due to missing IPV6_V6ONLY.
...
Thanks to Matt Ingenthron.
Closes #1212 .
2019-04-11 21:26:29 +01:00
Roger A. Light
cba3380b98
Fix mosquitto_sub encoding of special characters with %j format.
...
Thanks to Ben Barbour.
Closes #1220 .
2019-04-11 21:05:47 +01:00
Roger A. Light
4995436b5a
Add --repeat and --repeat-delay to mosquitto_pub.
2019-04-11 19:13:59 +01:00
Roger A. Light
dec769ce33
Client and doc ALPN additions
...
Add ALPN support for all clients, update documentation, and add to ChangeLog.
2019-04-11 11:52:34 +01:00
Roger A. Light
925debb8a5
Add mosquitto_rr, the "request-response" client.
2019-04-01 22:31:05 +01:00
Roger A. Light
1220ba4bfe
Rejig OCSP code.
2019-03-26 22:13:42 +00:00
Roger A. Light
42732f4cca
Fix mosquitto_passwd segfault on corrupt file.
...
Thanks to srasku-ge.
Closes #1207
2019-03-26 10:03:17 +00:00
Roger A. Light
320ddc1303
Merge branch 'master'
...
Conflicts:
CMakeLists.txt
ChangeLog.txt
client/Makefile
config.mk
installer/mosquitto.nsi
installer/mosquitto64.nsi
lib/mosquitto.h
lib/mqtt3_protocol.h
lib/util_mosq.c
set-version.sh
snap/snapcraft.yaml
src/bridge.c
src/database.c
src/handle_connack.c
src/loop.c
src/persist.c
test/broker/Makefile
2019-03-16 10:05:38 +00:00
Roger A. Light
a29238fc87
Update changelog.
2019-03-13 08:15:38 +00:00
Roger A. Light
6a1ac70ee6
Disallow writing to $ topics where appropriate.
2019-03-03 22:00:30 +00:00
Roger A. Light
1d4bf55165
Tidy previous commit and add to changelog.
2019-03-02 22:52:23 +00:00
Roger A. Light
1ce1bce941
Add --remove-retained to mosquitto_sub
...
This can be used to clear retained messages on a broker.
2019-03-02 22:14:54 +00:00
Roger A. Light
ce31269e05
Update changelog, bump version, bump copyright year.
2019-02-28 16:56:15 +00:00
Roger A. Light
7207041428
Fix delayed bridge local subs causing missing messages.
...
Closes #1174 . Thanks to beville.
Bug: https://github.com/eclipse/mosquitto/issues/1174
2019-02-28 15:38:15 +00:00
Roger A. Light
acf478eca2
Fix broken mosquitto_passwd on FreeBSD.
...
Closes #1032 . Thanks to jkoopman, Joseph Benden and Ari Suutari.
Bug: https://github.com/eclipse/mosquitto/issues/1032
2019-02-28 14:26:14 +00:00
Roger A. Light
4490d06a63
Coverity fixes.
...
1398654, 1398656 - lib missing unlock on fatal protocol error
1398655 - broker potential double free on startup after fatal persist
error.
2019-02-28 11:45:13 +00:00
Roger A. Light
463de0a2c1
Make error messages for missing config file clearer.
2019-02-28 11:13:47 +00:00
Roger A. Light
1924afe49e
Add explicit support for TLS v1.3 and drop TLS v1.0.
2019-02-27 22:50:01 +00:00
Roger A. Light
130ddf47f7
Add dhparamfile
option, to allow DH parameters to be loaded.
...
This is for Ephemeral DH support on listeners.
2019-02-27 22:26:40 +00:00
Roger A. Light
dfbd33e0f4
Update documentation for bridge backup, plus tweaks
...
Sets default to use the backoff mechanism.
2019-02-27 13:52:19 +00:00
Roger A. Light
e334aad853
Rewrite bind_interface docs, update changelog.
2019-02-27 10:07:14 +00:00
Roger A. Light
f4e24f9524
Use higher resolution timer for random client id generation.
2019-02-26 14:26:05 +00:00
Roger A. Light
5e8199323b
Fix clients being disconnected when ACLs are in use.
...
This only affects the case where a client connects using a username, and
the anonymous ACL list is defined but specific user ACLs are not
defined.
Closes #1162 . Thanks to quonb.
2019-02-14 17:46:01 +00:00
Roger A. Light
bb72cf9088
Bump version number, update webpage.
2019-02-13 23:49:17 +00:00
Roger A. Light
321e566af6
Fix unref'd messages being saved to the persistence file.
...
This was leaving dangling messages that were never freed.
Closes #389 . Thanks to pjchx.
2019-02-13 12:08:05 +00:00
Roger A. Light
1a6c3f0c86
Improve documentation around the include_dir
option.
...
Closes #1154 . Thanks to Guzoft.
2019-02-13 10:08:44 +00:00
Roger A. Light
084062c85e
Merge branch 'fixes' into mqtt5
2019-02-12 17:05:42 +00:00
Roger A. Light
9999faf9da
Add rewritten build test script and remove some build warnings.
2019-02-12 13:24:54 +00:00
Roger A. Light
e72d1d6ff5
Fix mosquitto_topic_matches_sub()
rc with sub=="topic/#abc".
...
This now returns MOSQ_ERR_INVAL as expected.
2019-02-12 11:26:23 +00:00
Roger A. Light
04e89450c0
Don't require C99 compiler.
2019-02-09 13:52:09 +00:00
Roger A. Light
715da28602
Fix include_dir not sorting config files before loading.
...
Thanks to momoskitto.
2019-02-08 23:52:11 +00:00
Roger A. Light
2e1c2c430f
per_listener_settings true
must come before other security settings.
...
Produce error if this is not the case. Closes #1164 , thanks to
momoskitto.
2019-02-08 23:14:43 +00:00
Roger A. Light
9378016b19
Fix build failure when using WITH_ADNS=yes
2019-02-08 21:34:08 +00:00
Roger A. Light
1b5c900e77
Update CVE details and bump version number.
2019-02-08 13:01:07 +00:00
Roger A. Light
1c075988ca
Log message for disconnecting a client with invalid UTF-8 topic.
...
Closes #1144 . Thanks to Kris Mattheus.
2019-02-08 13:01:07 +00:00
Roger A. Light
f952ae3a67
Fixed durable clients being unable to receive messages when offline.
...
This occurred when per_listener_settings was set to true.
Closes #1081 . Thanks to dwin-wangjt.
2019-02-08 13:01:07 +00:00
Roger A. Light
17b52bd5d1
Windows: Fix possible crash when client disconnects.
...
Closes #1137 . Thanks to Kris Mattheus.
2019-02-08 13:01:07 +00:00
Roger A. Light
d6a690aa8d
Fix Will not being sent for Websockets clients.
...
Closes #1143 . Thanks to salcedo.
2019-02-08 13:01:07 +00:00
Roger A. Light
ab8b57ff54
Allow broker to always restart on Windows when using log_dest file
.
...
Closes #1080 . Thanks to lcouz.
2019-02-08 13:01:07 +00:00
Roger A. Light
29a1936c77
Fix spaces not being allowed in the bridge remote_username option.
...
Closes #1131 . Thanks to beville.
2019-02-08 13:01:07 +00:00
Roger A. Light
ce1d0ae364
Man page can now be built on any system.
...
Closes #1139 . Huge thanks to Chris Mayo.
2019-02-08 13:01:07 +00:00
Roger Light
c40957a7d8
Fix and tests for CVE-2018-12546.
2019-02-08 13:01:07 +00:00
Roger A. Light
d8505624d0
Fix and tests for security bug #541870 .
2019-02-08 13:01:07 +00:00
Roger A. Light
36b5421c59
Fix and tests for security bug #543401 .
2019-02-08 13:01:07 +00:00
Roger Light
5236295159
Handle mismatched handshakes properly.
...
For example, a QoS1 PUBLISH with QoS2 reply.
2019-02-08 13:01:07 +00:00
Roger A. Light
495e9647c2
Improve bridge remapping documentation.
2019-02-08 13:01:07 +00:00
Roger A. Light
ad42f449d8
Update changelog for previous PR.
...
Thanks to Matthias Stone.
2019-02-08 13:01:07 +00:00
Roger A. Light
e8320cbf19
Fix TLS connections not working over SOCKS.
...
Thanks to Mark Oeltjenbruns.
2019-02-08 13:01:07 +00:00
Roger A. Light
a2b78d87a6
Update changelog
2019-02-08 13:01:07 +00:00
Roger A. Light
be9c1071b0
Fix compilation when openssl deprecated APIs are not available.
...
Closes #1094 . Thanks to Rosen Penev.
2019-02-08 13:01:07 +00:00
Roger A. Light
70c4097b6f
Fix comparison of boolean values in CMake build.
...
Closes #1101 . Thanks to Mojca Miklavec and Andrew L. Moore.
2019-02-08 13:01:07 +00:00
Roger A. Light
4a2e569171
-V now accepts 5,
311,
31, as well as
mqttv5` etc.
2019-01-09 18:06:20 +00:00
Roger A. Light
2f54b16544
Fix mosquitto_pub not always sending everything with -l and QoS>0.
2019-01-08 14:19:50 +00:00
Roger A. Light
19fbbd8726
Update details of CVE-2018-20145.
2018-12-20 18:45:01 +00:00
Roger A. Light
fcf4cd0b27
Merge branch 'master' into mqtt5
2018-12-19 14:11:11 +00:00
Roger A. Light
a8ca5c83af
Bump version.
2018-12-11 11:13:09 +00:00
Roger A. Light
89f3d7bb3f
Don't print connect/disconnect messages when connection_messages false.
...
Closes #772 . Closes #613 . Closes #537 .
Thanks to Christopher Maynard, Brandon Arrendondo, and qubeck.
2018-12-11 10:55:39 +00:00
Roger A. Light
a00dd29af8
Fix building where TLS-PSK is not available.
...
Closes #68 .
2018-12-11 10:55:31 +00:00
Roger A. Light
9097577b49
Fix acl_file being ignore for default listener if with per_listener_settings
...
Close #1073 . Thanks to Jef Driesen.
Bug: https://github.com/eclipse/mosquitto/issues/1073
2018-12-09 21:23:46 +00:00
Roger A. Light
73c46174f8
Don't call on_disconnect() twice if keepalive tests fail.
...
Closes #1067 . Thanks to xingchen02.
Bug: https://github.com/eclipse/mosquitto/issues/1067
2018-12-06 10:45:57 +00:00
Roger A. Light
6ef2c79e9a
Add max_keepalive, for limiting keepalives of MQTT v5 clients.
2018-12-06 08:49:02 +00:00
Roger A. Light
48c2217015
auto_id_prefix now defaults to 'auto-'.
2018-12-05 17:17:35 +00:00
Roger A. Light
1d3949bce0
Improve broker generated client ids for the non-Linux case.
...
Removes libuuid dependency.
2018-12-05 16:39:45 +00:00
Roger A. Light
3a871828ac
Print message on error when installing as a Windows service.
2018-12-05 11:25:41 +00:00
Roger A. Light
c9ed2708f6
Don't reload auth_opt_ options on reload.
...
This matches the behaviour of the other plugin options.
Closes #1068 . Thanks to Jason McFadyen.
Bug: https://github.com/eclipse/mosquitto/issues/1068
2018-12-04 20:51:25 +00:00
Roger A. Light
464b12f3d6
Fix outgoing retained messages not being sent by bridges.
...
This now happens on initial connection, after CONNACK is processed,
before it was happening (and being dropped) before the connection was
made.
Closes #1040 . Thanks to giover.
Bug: https://github.com/eclipse/mosquitto/issues/1040
2018-12-04 20:45:15 +00:00
Roger A. Light
5d02f58151
Fix reconnect delay backoff behaviour.
...
Closes #1027 . Thanks to Harm Verhagen.
Bug: https://github.com/eclipse/mosquitto/issues/1027
2018-12-04 17:19:31 +00:00
Roger A. Light
e169f1c7c2
When using ADNS, don't ask for all network protocols when connecting.
...
This can lead to confusing "Protocol not supported" errors if the
network is down, because UDP sockets are provided.
Thanks to jsaak.
Closes #1062 .
Bug: https://github.com/eclipse/mosquitto/issues/1062
2018-12-04 12:39:00 +00:00
Roger A. Light
d29dac087d
Add socket_domain option.
2018-12-04 11:48:29 +00:00
Roger A. Light
34293d07c1
Always print leading zeros in mosquitto_sub when output format is hex.
...
Closes #1066 .
Thanks to skiizo.
Bug: https://github.com/eclipse/mosquitto/issues/1066
2018-12-04 09:24:04 +00:00
Roger A. Light
b54e379fba
Fix websockets listeners not verifying client certs.
...
When using a TLS enabled websockets listener with "require_certificate"
enabled, the mosquitto broker does not correctly verify client certificates.
This is now fixed. All other security measures operate as expected, and in
particular non-websockets listeners are not affected by this. Closes #996 .
Thanks to creising.
2018-11-08 12:10:28 +00:00
Roger A. Light
71b8c4d892
Fix TLS connections when using an external event loop.
...
Affects the use of mosquitto_loop_read() and mosquitto_write().
Closes #990 .
2018-11-07 21:08:10 +00:00
Roger A. Light
b803b40a22
Update changelog.
2018-11-07 18:32:17 +00:00
Roger A. Light
34c752a0d0
Give better error message if a client sends a password without a username.
...
Closes #1015 . Thanks to TabascoEye.
2018-11-07 17:29:39 +00:00
Roger A. Light
9f7577aab6
$SYS/broker/clients/disconnected should never be negative.
...
Closes #287 . Thanks to Lovisa Johansson.
Bug: https://github.com/eclipse/mosquitto/issues/287
2018-11-07 17:23:43 +00:00
Roger A. Light
d7bcec4878
Don't disconnect clients when a plugin denies SUBSCRIBE.
...
Thanks to Ibrahim Koujar.
Bug: https://github.com/eclipse/mosquitto/issues/1016
2018-11-07 10:06:32 +00:00
Roger A. Light
eff8fab1b4
Only process network errors for clients that have nothing to read.
...
Closes #7 .
2018-11-06 23:02:33 +00:00
majekw
7f1419e4de
Fix mosquitto_pub -l if compiled using cmake.
...
Since dde005ef92
mosquito_pub is throwing error
that 'threading support has not been compiled' when compiled using cmake.
It looks like WITH_THREADING flag is not set at top level Makefile and used
only in lib/ directory, so library is correctly compiled with threading.
But for client this flag is undefined, so it gives error on '-l' option.
This commit moves part related to WITH_THREADING flag out of lib/CMakeLists.txt
to top levele CMakeLists.txt, so it could be accessible to all subdirectories.
Signed-off-by: Marek Wodzinski <majek@w7i.pl>
2018-10-23 18:56:00 +01:00
Roger A. Light
0a9ee5b4cf
Fix memory leak when reconnecting with TLS errors.
...
Fix memory leak that occurred if mosquitto_reconnect() was used when TLS
errors were present.
Closes #592 . Thanks to smartdabao and aaronovz1.
2018-10-23 10:46:55 +01:00
Roger A. Light
1867f30785
Merge branch 'master'
...
Conflicts:
ChangeLog.txt
2018-10-02 08:31:54 +01:00
Roger A. Light
0e76bed50e
Add -E option to mosquitto_sub.
...
This causes the client to exit immediately after its subscriptions are
acknowledged by the broker, and can be used to create a durable client
session without requiring messages to be delivered.
Closes #952 .
2018-09-27 22:21:42 +01:00
Roger A. Light
8b66a323cd
Add mosquitto_subscribe_multiple()
...
For sending subscriptions to multiple topics in one command.
2018-09-27 22:06:54 +01:00
Roger A. Light
c78003cacf
Bump version number, add CVE details.
2018-09-25 16:26:28 +01:00
Roger A. Light
588d39efdc
Fix Windows version not starting if include_dir did not contain any files.
...
Closes #566 .
Thanks to marleau.
2018-09-25 16:14:57 +01:00