Commit Graph

2348 Commits

Author SHA1 Message Date
Roger A. Light
c5ba597588 Fix use after free (unreleased) 2020-11-06 11:19:27 +00:00
Roger A. Light
255ae24a6d Fix basic dynsec tests. 2020-11-05 23:48:11 +00:00
Roger A. Light
c2651cf005 Remove deprecation warning on libmosquittopp. 2020-11-05 22:38:35 +00:00
Roger A. Light
693f6ad36e Only make keepalive checks every 5 seconds. 2020-11-05 21:43:23 +00:00
Roger A. Light
23d3c2641e Optimise epoll event to context/listener mapping. Allows quicker lookups. 2020-11-05 16:10:50 +00:00
Roger A. Light
95139cccff Dynsec: If priority is equal when ordering, use group/role name as well. 2020-11-05 12:23:53 +00:00
Roger A. Light
2a1df4ddb2 Breaking: Drop privileges after loading the configuration
This change means privileges are dropped before loading certificates, starting logging, creating the pid file etc. are carried out, so all of those actions must now be changed to ensure that the unprivileged user can carry them out.
2020-11-05 12:05:07 +00:00
Roger A. Light
c5fee09c24 Basic client disconnect event support for plugins. 2020-11-05 10:52:21 +00:00
Roger A. Light
4d6384c758 Build and conversion fixes for build variants. 2020-11-05 10:23:01 +00:00
Roger A. Light
4d9afc835b Fix missing functions in test. 2020-11-05 09:06:51 +00:00
Roger A. Light
e6dd08074d TLS certificates for the server are now reloaded on SIGHUP. 2020-11-04 22:57:10 +00:00
Roger A. Light
b2560f5e06 Move certificate loading to its own function. 2020-11-04 22:21:17 +00:00
Roger A. Light
24462a816b Tidy up headers. 2020-11-04 22:20:50 +00:00
Roger A. Light
aafb75b6bc Ctrl: Fix use of ints in cJSON. 2020-11-04 13:58:40 +00:00
Roger A. Light
801e31efda Dynsec: Validate user/group/role names as UTF-8. 2020-11-04 13:32:27 +00:00
Roger A. Light
7462fec1c8 Dynsec: Check ACLs are valid topic filters. 2020-11-04 12:20:14 +00:00
Roger A. Light
3486f0e546 Dynsec: Kick affected clients on role change. 2020-11-04 10:18:30 +00:00
Roger A. Light
9785896eea Ctrl: Report errors on invalid args, don't try to connect. 2020-11-03 18:15:46 +00:00
Roger A. Light
bb840ed55b Conversion fixes. 2020-11-03 10:09:18 +00:00
Roger A. Light
8e7e4a9d9a Clients: Give warning if keepalive too low. 2020-11-03 09:51:28 +00:00
Roger A. Light
1191a42c2e Fix more incorrect quota handling.
Must check QoS, and directions were wrong.
2020-11-02 23:14:21 +00:00
Roger A. Light
042c2733f2 Test and fix for message expiry not increasing send quota. 2020-11-02 23:09:18 +00:00
Arenoros
9c3a214a01 In android ndk doesn't exist librt and libpthread
Signed-off-by: Arenoros <arenoros@gmail.com>
2020-11-02 21:36:24 +00:00
raspopov
add355a78b QNX has no pselect() either.
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
2020-11-02 21:33:09 +00:00
raspopov
aed4b945d9 Fixed QNX compilation. QNX 6.5 supports _XOPEN_SOURCE=600 or less.
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
2020-11-02 21:31:23 +00:00
Roger A. Light
92a1a02430 Tag local docker builds. 2020-11-02 13:05:59 +00:00
Roger A. Light
a3bff44a3e Split mosquitto_ctrl manpages by module. 2020-11-01 23:49:40 +00:00
Roger A. Light
bb03b9c081 Let mosquitto_ctrl load external modules.
Also provide an example.
2020-11-01 22:59:39 +00:00
Roger A. Light
97385f522b Ctrl: Client only deals with a payload string, not cJSON. 2020-11-01 22:11:32 +00:00
Roger A. Light
2e72d795a9 Fix timeout conversion error. 2020-10-30 21:31:13 +00:00
raspopov
0097a85ce0 Something bad happened with a "timeout" parameter of mosquitto_loop() function in 4f61f6c161. Reverted.
Signed-off-by: raspopov <raspopov@cherubicsoft.com>
2020-10-30 18:40:22 +00:00
Roger A. Light
866c395dcc Dynsec: Add "disabled" property for getClient/listClients. 2020-10-30 12:35:34 +00:00
Roger A. Light
5b28fac61d Dynsec: Kick clients on access changes
This works in the following circumstances:

* client is deleted
* client is modified
* client has role added
* client has role removed
* group is deleted
* group is modified
* group has role added
* group has role removed
* group has client added
* group has client removed
* anonymous group is changed

The following circumstances are not yet fixed:

* role is deleted
* role is modified
* role has ACL added
* role has ACL removed
2020-10-30 12:35:02 +00:00
Roger A. Light
30bf47b0d1 Fix printing of ints in dynsec json. 2020-10-29 23:51:32 +00:00
Roger A. Light
e95327789e Note that zero length retained messages are never retained.
Closes #1871. Thanks to James Kleeh.
2020-10-29 19:39:50 +00:00
Roger A. Light
66d16280d8 dynsec: Add enableClient disableClient commands. 2020-10-29 15:17:12 +00:00
Roger A. Light
98815c5037 ctrl: Ask for passwords if not given.
Applies to login user, init, createClient, and setClientPassword.
2020-10-29 14:35:50 +00:00
Roger A. Light
31b1cbb23f dynsec: Clients can be created with no password.
They will be unable to log in until a password is created.
2020-10-29 14:35:11 +00:00
Roger A. Light
99a544ac73 ctrl: Ask for login password if the user doesn't provide it. 2020-10-29 12:49:51 +00:00
Roger A. Light
1b3dc5e978 passwd: Move password getting code to own file for sharing. 2020-10-29 12:48:59 +00:00
Roger A. Light
df30b6c9d4 Dynsec: add getAnonymousGroup and getDefaultACLAccess commands 2020-10-29 11:38:34 +00:00
Roger A. Light
c9cb10a079 ctrl: get* output for dynsec. 2020-10-29 09:59:07 +00:00
Roger A. Light
4c427915a0 ctrl: Fix acltype names. 2020-10-28 16:18:08 +00:00
Roger A. Light
015eee6cb6 ctrl: Fix parameter order to match docs. 2020-10-28 16:17:51 +00:00
Roger A. Light
1e2ba03754 ctrl: Give dynsec init user more rights.
Subscribe and receive from $SYS/#
Subscribe and receive from #
2020-10-28 11:50:52 +00:00
Roger A. Light
1f0ae42917 ctrl: Fix incorrect dynsec commands. 2020-10-28 11:46:13 +00:00
Roger A. Light
fcb8bc0b9b Fix use of incorrect callback list. 2020-10-28 11:23:48 +00:00
Roger A. Light
a1ad4cfcc4 Dynsec: Rename ACL types for clarity.
publishBrokerToClient -> publishClientReceive
publishClientToBroker -> publishClientSend
2020-10-28 11:03:44 +00:00
Roger A. Light
004bd3c5cd Dynsec: Set default behaviour to be less restrictive.
Publish broker to client and unsubscribe are now allowed by default. With Publish client to broker and subscribe denied by default there is still no way a client can exchange messages, but it is now easier to administer.
2020-10-28 11:03:44 +00:00
Roger A. Light
e01d391c0b Fix crash on Windows if loading a plugin fails.
Closes #1866. Thanks to roebotron.
2020-10-27 18:25:00 +00:00