Roger A. Light
35dea07dcd
Merge branch 'master'
2018-10-23 10:39:20 +01:00
Vinod Kumar
e492a61cd8
return MOSQ_ERR_INVAL if config has invalid boolean value
...
Signed-off-by: Vinod Kumar <kumar003vinod@gmail.com>
2018-09-29 07:51:12 +01:00
Roger A. Light
588d39efdc
Fix Windows version not starting if include_dir did not contain any files.
...
Closes #566 .
Thanks to marleau.
2018-09-25 16:14:57 +01:00
Roger A. Light
f9c9f3d396
Fix incorrect hash usage with duplicate clients.
...
Fix duplicate clients being added to by_id hash before the old client
was removed.
Closes #645 .
2018-09-25 14:25:54 +01:00
Roger A. Light
7b1892caef
Fix retained msgs not sent by bridges.
...
This occurred when a bridge connected for the first time and so made a
local subscription for outgoing topics.
Closes #701 .
2018-09-25 14:25:54 +01:00
Roger A. Light
f7474d3482
Revert "Remove some test that was always true"
...
This reverts commit 6fc7cadb63
.
2018-09-25 14:25:54 +01:00
Kurt Van Dijck
e3b4bd8937
fix signal handler on win32
...
The signal handler thread on win32 did listen to 4 HANDLEs,
of which only 3 were initialized.
The result was 1 thread eating 100% cpu.
This commit reduces the HANDLE array storage.
Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
2018-09-25 10:34:28 +01:00
Roger A. Light
7ca3a24686
Remove requirement to use user root
in snap package config files.
2018-09-20 12:05:02 +01:00
Roger A. Light
0e16a248f2
Elevate log level to warning for situation when socket limit is hit.
2018-09-20 12:00:51 +01:00
Roger A. Light
55ca61f14e
Fix segfault on HUP when bridges and security options are configured.
...
Closes #849 . Closes #965 . Thanks to Wolfgand Hottgenroth and Dustin Sallings.
2018-09-19 17:52:23 +01:00
Roger A. Light
2b4ba10b3d
Fix "round_robin false" behaviour.
...
Closes #481 .
2018-09-19 17:30:38 +01:00
Roger A. Light
3ae387e232
Close spare sock at exit.
2018-09-19 13:01:13 +01:00
Roger A. Light
1e47ee4cad
Fix for bridge connections when using WITH_ADNS=yes.
2018-09-19 12:55:08 +01:00
Roger A. Light
d1b36507db
Better implementation of #948 .
2018-09-18 12:08:49 +01:00
Roger A. Light
ee8e20de75
Fix excessive CPU usage when the number of sockets exceeds the system limit.
...
Closes #948 . Thanks to wiebeytec.
2018-09-18 11:54:58 +01:00
Roger A. Light
dceb02f444
Make it easier to build without bundled uthash.h.
...
Use "make WITH_BUNDLED_DEPS=no".
2018-09-08 10:24:12 +01:00
Roger A. Light
e6a0199bb2
Fix incorrect call to setsockopt() for TCP_NODELAY.
...
Closes #941 . Thanks to rfalke.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-30 21:01:43 +01:00
Roger A. Light
2221deb7a7
Fix build when using WITH_ADNS=yes.
2018-08-30 20:44:17 +01:00
Roger A. Light
11395f9852
Fix accessor functions for username and client id when used in plugin auth check.
2018-08-16 17:00:00 +01:00
Roger A. Light
9d157f86ff
Fix for building on Windows with static lws.
2018-08-16 13:31:15 +01:00
Roger A. Light
14bd96e1e1
Add support for compiling with static libwebsockets library.
2018-08-16 11:28:26 +01:00
Roger A. Light
88765a5e80
Consistent use of config.h across the project.
2018-08-16 11:14:51 +01:00
Roger A. Light
0a4810286b
Check for 918
2018-08-15 17:41:14 +01:00
Roger A. Light
a199cac69e
Don't confuse expiring and duplicate clients.
2018-08-15 17:27:59 +01:00
Roger A. Light
ab5af8f0b9
Fix building for libwebsockets < 1.6.
2018-08-14 17:20:22 +01:00
Pierre Fersing
6fc7cadb63
Remove some test that was always true
...
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
2018-08-14 14:56:07 +01:00
Roger A. Light
af2678ea49
Fix possible endian issue when reading the memory_limit
option.
...
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-09 22:31:03 +01:00
Roger A. Light
945b3283a6
No need to calculate topic len twice.
2018-08-09 15:37:26 +01:00
Tatsuzo Osawa
cb56a75bbb
Fix subs memory issue #505
...
Signed-off-by: Tatsuzo Osawa <tatsuzo.osawa@gmail.com>
2018-08-09 15:25:52 +01:00
Roger A. Light
10b19a42ed
Fixes for building on NetBSD.
...
Closes #258 .
Thanks to Daniel Ölschlegel.
2018-08-09 15:21:40 +01:00
Roger A. Light
ecb4006f38
Don't reject ACL patterns without %u or %c, just warn.
...
Using `pattern blah/#` is a legitimate method of getting a global ACL.
We shouldn't be changing behaviour in a fixes release.
2018-08-09 14:32:02 +01:00
Natanael Copa
9e92cb0129
Flush stdout when asking for password.
...
Make sure the prompt is actaually printed by flushing stdout when asking
for passwords.
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
2018-08-09 13:47:11 +01:00
Tobias Assarsson
cc96485330
Add missing parameters to internal mosquitto_acl_check
...
Signed-off-by: Tobias Assarsson <tobias.assarsson@gmail.com>
2018-08-09 13:05:35 +01:00
Roger A. Light
7c94a73c17
Fix UNSUBACK messages not being logged.
...
Closes #903 .
Thanks to Christoph Krey.
2018-08-09 11:54:24 +01:00
Roger A. Light
0d25cb58b4
Fix use_identity_as_username true
not working.
...
Closes #833 .
Thanks to David Crook and Brice Waegeneire.
Bug: https://github.com/eclipse/mosquitto/issues/833
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-08 15:36:42 +01:00
bricewge
2a3305a4a2
fix #833
...
Signed-off-by: Brice Waegeneire <brice.wge@gmail.com>
2018-08-08 15:27:05 +01:00
Roger A. Light
e185d18917
Better fix for #851 .
...
Ensure all sockets that are closed are set to INVALID_SOCKET.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-08 15:23:03 +01:00
Wolfgang Hottgenroth
88456c655f
Move check whether context is a bridge in front of check whether a listener
...
exists for context. New test now passes.
Signed-off-by: Wolfgang Hottgenroth <wolfgang.hottgenroth@icloud.com>
2018-08-08 13:42:50 +01:00
Roger A. Light
39170d1181
ACL patterns that do not contain either %c or %u are now rejected.
...
Closes #209 .
Bug: https://github.com/eclipse/mosquitto/issues/209
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-08 13:15:54 +01:00
Pierre Fersing
abaceb9c9e
Fix missing rename of mosquitto__socket_get_address
...
Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
2018-08-02 21:32:08 +01:00
Roger A. Light
2f6f5dbf9d
Fix problem on Pi caused by unsigned char being default.
...
Found via #849 .
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 21:06:47 +01:00
Roger A. Light
fc9a0db966
All clients now time out if they exceed their keepalive*1.5
...
This was inconsistent before.
Partially addresses #865 .
2018-08-02 13:05:36 +01:00
Roger A. Light
b07e0c08bf
Fix IPv6 addresses not being able to be used as bridge addresses.
...
Closes #886 .
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 13:01:02 +01:00
Roger A. Light
bcf76b9cb6
Remove use of AI_ADDRCONFIG.
...
Closes #869 , #901 .
Thanks to Alex Richman.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 01:11:31 +01:00
Roger A. Light
286400abcf
Use AF_UNSPEC etc. instead of PF_UNSPEC to comply with POSIX.
...
Closes #863 .
Thanks to denigmus and Patrick TJ McPhee.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-02 00:27:52 +01:00
Roger A. Light
a954081673
Print more OpenSSL errors when loading certificates/keys fail.
...
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-01 21:24:02 +01:00
Dave Miller
81a82f6fe2
Fix for issue #874
...
With special acknowledgement to sxsing (his github login) for his
help in development and testing of this fix.
NOTE: Pull-request is against master as the fixes branch has not
been updated with the v1.5 file src/handle_connect.c
Signed-off-by: Dave Miller <dmiller@tibco.com>
2018-08-01 19:30:40 +01:00
Roger A. Light
8bbb5887d0
[Broker] Fix auth plugin cleanup function not being called.
...
Closes #900 .
Thanks to Julian Zhao.
Signed-off-by: Roger A. Light <roger@atchoo.org>
2018-08-01 15:53:29 +01:00
Roger A. Light
5e60136449
Merge branch 'develop'
2018-05-03 07:55:45 +01:00
Roger A. Light
e9d03c8ffd
Merge branch 'fixes'
2018-05-02 22:33:27 +01:00