Commit Graph

806 Commits

Author SHA1 Message Date
Roger A. Light
11975332d4 Fix mosquitto_topic_matches_sub2() not using the length parameters.
Closes #2364. Thanks to Jens Alfke.
2021-11-16 23:14:24 +00:00
Roger A. Light
94d61305fa Fix bridge not respecting receive-maximum when reconnecting with MQTT v5. 2021-11-09 13:53:37 +00:00
Roger A. Light
292e969140 Bump version, update web. 2021-10-27 16:40:21 +01:00
Roger A. Light
46a6c5d17b Fix mosquitto_plugin.h not including mosquitto_broker.h.
Closes #2350. Thanks to Wolfgang Petroschka.
2021-10-27 16:23:20 +01:00
Roger A. Light
20d2935d81 Fix date format in mosquitto_sub output.
Closes #2353. Thanks to Norman Rasmussen.
2021-10-27 16:22:26 +01:00
Roger Light
5cae4d1d81 Fix broker sending duplicate CONNACK on failed MQTT v5 reauthentication.
Closes #2339. Thanks to hvxl.
2021-10-12 22:33:05 +01:00
Roger A. Light
be80a3f4d0 Fix client id not showing in log on failed connections, where possible. 2021-10-06 10:09:38 +01:00
Roger A. Light
a1a190b482 Pointless whitespace tidy. 2021-10-05 15:20:37 +01:00
Roger A. Light
0ce167c472 Fix log file being truncated on Windows. 2021-10-05 11:33:35 +01:00
Roger A. Light
7061569bf4 Don't send retained messages when a shared subscription is made. 2021-10-04 16:26:58 +01:00
Roger A. Light
9e28eea0a2 Initialise sockpairR/W to invalid in mosquitto_reinitialise()
This avoids closing invalid sockets in `mosquitto_destroy()` on error.

Closes #2326. Thanks to Arrigo Zanette.
2021-09-24 16:50:53 +01:00
Roger A. Light
7b58eee414 Fix problem parsing config files with Windows line endings.
Closes #2297. Thanks to all the people who commented there!
2021-09-23 11:40:40 +01:00
Roger A. Light
330bf6efdc Various fixes around inflight quota management.
Closes #2306. Thanks to canique.
2021-09-22 17:20:24 +01:00
Roger A. Light
7551a29985 Fix LWT messages not being delivered if per_listener_settings was set to true
Closes #2314. Thanks to Marc Hamel.
2021-09-21 22:51:25 +01:00
Roger A. Light
d942ed7eec Fix max_keepalive option not being able to be set to 0. 2021-09-09 12:19:13 +01:00
Roger A. Light
42acfdad41 Bump version, update web page. 2021-08-31 17:16:52 +01:00
Roger A. Light
c6859366c4 Merge branch 'fixes' 2021-08-31 16:44:24 +01:00
Roger A. Light
d09591d92e Fix reconnecting in some cases when using MOSQ_OPT_TLS_USE_OS_CERTS.
Fix reconnecting failing when MOSQ_OPT_TLS_USE_OS_CERTS was in use, but none
of capath, cafile, psk, nor MOSQ_OPT_SSL_CTX were set, and
MOSQ_OPT_SSL_CTX_WITH_DEFAULTS was set to the default value of true.

Closes #2288. Thanks to Poltorak Serguei.
2021-08-31 15:59:40 +01:00
Roger A. Light
e43d36020f Update plugin configuration documentation.
Closes #2286. Thanks to Karl Palsson.
2021-08-31 10:57:48 +01:00
Roger A. Light
605131502b Fix MOSQ_OPT_SSL_CTX not being able to be set to NULL.
Closes #2289. Thanks to Poltorak Serguei.
2021-08-31 10:45:10 +01:00
Roger A. Light
77af2ecefe Fix mosquitto_ctrl dynsec setDefaultACLAccess command not working. 2021-08-30 22:28:51 +01:00
Roger A. Light
06c84aeb66 CVE-2021-34434 details. 2021-08-30 22:06:32 +01:00
Roger A. Light
37b5aedcb6 Fix for #575314.
Incoming QoS 2 messages that had not completed the QoS flow were not being
checked for ACL access when a clean session=False client was reconnecting.

Closes #575314.
2021-08-30 16:14:27 +01:00
Roger A. Light
9d6a73f9f7 Fix CONNECT performance with many user-properties.
An MQTT v5 client connecting with a large number of user-property properties
could cause excessive CPU usage, leading to a loss of performance and
possible denial of service. This has been fixed.
2021-08-26 12:17:42 +01:00
Roger Light
32af599c81 Fix $share subscriptions not being recovered for durable clients.
If a plugin had granted ACL subscription access to a
durable/non-clean-session client, then removed that access, the client would
keep its existing subscription. This has been fixed.
2021-08-26 12:17:26 +01:00
Roger A. Light
756b3fcb08 Document TLS certificate behaviour when using -p 8883. 2021-08-24 23:15:06 +01:00
Roger A. Light
f952d19da1 Fix printf format build warning on MIPS.
Closes #2271. Thanks to Karl Palsson.
2021-08-24 13:58:15 +01:00
Roger A. Light
9b25dd3b0d libressl build fixes.
Closes #2198. Thanks to Theo Buehler.
2021-08-24 13:53:03 +01:00
Roger A. Light
0d1837ebe3 Deconfigure thread mode when the loop thread ends.
Threaded mode is deconfigured when the mosquitto_loop_start() thread ends,
which allows mosquitto_loop_start() to be called again.

Closes #2242. Thanks to Timo Lange.
2021-08-24 11:51:38 +01:00
Roger Light
ba2ca33671 Strict protocol compliance fixes, and extensive test suite. 2021-08-23 23:19:28 +01:00
Roger Light
723b5d7081 Fix listener mount_point not being removed on outgoing messages.
Closes #2244. Thanks to alflexRH.
2021-08-22 08:23:13 +01:00
Roger Light
6608e852a1 Fix broker not quiting if password_file is specified as a directory.
Closes #2241. Thanks to Bryan Pearson.
2021-08-21 22:45:39 +01:00
Roger Light
526b8430e2 Fix for #2283.
Closes #2283. Thanks to Heath Raftery.
2021-08-21 20:14:51 +01:00
Roger Light
c01ae67af7 Fix openssl not being linked to dynamic security plugin.
Closes #2277. Thanks to LeSuisse.
2021-08-21 09:45:26 +01:00
Roger Light
342aa0ad1a Fix installation using WITH_TLS=no.
Closes #2281. Thanks to Matt Turner.
2021-08-20 23:49:59 +01:00
Roger Light
93b2232bb9 Apply max_keepalive to MQTT v3.1.1 and v3.1 clients. 2021-08-20 23:27:14 +01:00
Roger A. Light
ea371564e7 Disable TLS 1.3 when using TLS-PSK, because it isn't correctly config'd. 2021-08-19 17:26:04 +01:00
Roger A. Light
0143db71a1 Fix TLS certs and PSK not being able to be config'd at the same time. 2021-08-19 17:26:04 +01:00
Roger A. Light
a37c8e65d2 TLS-PSK mismatch fix.
Produce an error if a TLS-PSK client tries to connect to a broker
that is not configured with TLS-PSK.
2021-08-19 17:26:04 +01:00
Roger A. Light
79542158f4 Fix max_connections option not being correctly counted. 2021-08-17 13:10:18 +01:00
Roger A. Light
8589f082d8 Fix CVE references. 2021-08-05 16:10:43 +01:00
Roger A. Light
4e146b7b53 Fix possible out of bounds memory reads when reading configuration.
This would happen with a corrupt/crafted configuration file. Unless your
configuration file is writable by untrusted users this is not a risk.

Closes #567213. Thanks to Roland Sako.
2021-07-22 16:43:06 +01:00
Roger A. Light
6028d0e33e mosquitto_sub and mosquitto_rr now open stdout in binary mode on Windows
This is so binary payloads are not modified when printing.

Thanks to Steve Mullock.
2021-06-09 21:16:57 +01:00
Roger A. Light
f68c052c79 Merge branch 'fixes' 2021-06-09 13:22:56 +01:00
Roger A. Light
99d7299b24 Fix qos0 messages not being queued when queue_qos0_message enabled.
Closes #2224. Thanks to Luigi Caiffa.
2021-06-09 13:21:27 +01:00
Roger A. Light
42163634c7 Fix leak on crafted MQTT v5 CONNECT.
If a MQTT v5 client connects with a crafted CONNECT packet a memory leak
will occur.

Thanks to Kathrin Kleinhammer.
2021-06-08 22:26:09 +01:00
Roger A. Light
238b68686a Fix bridge pollfd corruption on Windows.
Closes #2173. Thanks to Niclas Lindgren.
2021-06-08 13:29:29 +01:00
Roger A. Light
104b94db57 Fix non-reachable bridge blocking the broker on Windows.
Closes #2172. Thanks to Niclas Lindgren.
2021-06-08 12:07:24 +01:00
Roger A. Light
16fb0025a7 Improve QoS 0 outgoing packet queueing. 2021-05-18 16:53:45 +01:00
Roger Light
880df7360d Fix bridge not reconnectng if the first reconnection attempt fails.
Closes #2207. Thanks to Abilio Marques.
2021-05-17 00:49:44 +01:00