d0kuhn/mosquitto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,209 Commits 1 Branch 0 Tags 11 MiB
0b414c6fff
Commit Graph

2209 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Roger A. Light
4e1e0f955f Record of which client argument letters are in use. 2020-01-30 11:09:04 +00:00
Roger A. Light
50735afb5b Fix for internal logging not printing. 2020-01-29 16:25:56 +00:00
Panagiotis Vasilikos
618413e1d2 Resource leak in persist_read.c 
Reason: In lines 435 and 439, the function returns without calling closing
fptr which was opened at line 399.

Fix: I added fclose(fptr) statements before each of the returns.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
 2020-01-29 13:30:24 +01:00
Panagiotis Vasilikos
dd6d8237cb Potential Null pointer dereference in util_mosq.c 
Reason: There is no check that the mosquitto__malloc at line 162 was sucessfull.
This could result to a Null pointer dereference in the memcpy call at line 166.

Fix: I added the check.
Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
 2020-01-29 10:17:58 +01:00
Roger A. Light
8f1c8cba59 Set minimum keepalive argument to mosquitto_connect*() to be 5 seconds. 
Closes #1550. Thanks to Markus Gothe.
 2020-01-28 16:59:20 +00:00
Roger A. Light
9ae38788dc Fix config->user not being freed on exit. 
Closes #1564. Thanks to back1127.
 2020-01-28 16:52:14 +00:00
Roger A. Light
812c0636d5 Satisfy valgrind when exiting on error. 
This is when due to not being able to open a listening socket, solved by
calling freeaddrinfo in the error cases.

Closes #1565. Thanks to back1127.
 2020-01-28 16:12:45 +00:00
Roger A. Light
e7c9f009bd Strip whitespace from end of config file string options. 
Closes #1566. Thanks to kollokollo.
 2020-01-28 16:04:25 +00:00
Panagiotis Vasilikos
49bf788862 Memory leak in handle_unsubscribe.c 
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.

Fix: I added a mosquitto__free(reason_codes) statement before each return
statement that could result to a memory leak

Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
 2020-01-28 16:31:15 +01:00
Panagiotis Vasilikos
caeb211cc5 Memory leak in socks_mosq.c 
Reason: The memory allocated for the packet pointer at line 155 is not freed
before returning at line 188.

Fix: I inserted the mosquitto__free(packet) statement just before returning
at line 188.

Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
 2020-01-28 11:34:11 +01:00
Panagiotis Vasilikos
0f7052564c Memory leak in handle_unsubscribe.c 
Reason: In line 70, the memory allocation for the pointer reasons_codes may
result to a memory leak due to the many returns (e.g as the one in line 78)
occuring in the program's path until reaching the mosquitto__free at line 122.

Fix: I moved the memory allocation code block (lines 69-73) just before
the line 102. This is the first place the pointer reason_codes is used, while
the following mosquitto__free operators free the allocated memory correctly.

Signed-off-by: Panagiotis Vasilikos <panagiotis.vasilikos@alexandra.dk>
 2020-01-24 16:34:56 +01:00
Roger A. Light
4408339dbc Make consts unsigned where they are compared against unsigned. 2020-01-23 12:51:47 +00:00
Roger A. Light
5528dde56a Fix possible null dereferences. 2020-01-23 12:51:12 +00:00
Roger A. Light
05ec02b3f3 Remove dead values. 2020-01-23 10:55:49 +00:00
Roger A. Light
18f0508a6e Fix dereference before null check. 
Coverity Scan 1405815.
 2020-01-23 10:08:26 +00:00
Roger A. Light
db62f9843f Fix unused value being overwritten. 
Coverity Scan 1400727.
 2020-01-23 09:35:28 +00:00
Roger A. Light
6aa9b91fff Add testing target for compiling test client fixes. 2020-01-02 21:40:03 +00:00
Roger A. Light
d452ea138b Use presence of password file as indicator for authentication checks. 
Previously, authentication checks would only take place if usernames
were defined in the password file.

Closes #1545. Thanks to Timothy Godfrey.
 2019-12-20 00:19:17 +00:00
Roger A. Light
b6119bb759 Check ACL patterns for validity when loading. 
Closes #1539. Thanks to Leon Poon.
 2019-12-18 21:39:27 +00:00
Roger A. Light
d60e86d2a3 Add TCP_NODELAY support to lib and clients. 
Closes #1526. Thanks to Felix Moessbauer.
 2019-12-18 17:04:43 +00:00
Christian Schneider
a3ebeff9d7 fix: replace sleep with (p)select in loop_forever 
sleep was blocking loop_stop(force=false) since it
was uniteruptible

Signed-off-by: Christian Schneider <cschneider@radiodata.biz>
 2019-12-18 18:01:50 +01:00
Roger A. Light
adb6f3a39d Update Debian repo post to include up to date Debian dists. 2019-12-18 14:44:29 +00:00
Roger A. Light
e5561cd09e Fix db_dump compilation. 
Closes #1520.
 2019-12-12 16:54:23 +00:00
Roger A. Light
36ec665ec8 Basic subscribe example. 2019-12-12 13:46:45 +00:00
Roger A. Light
5cc16a4722 Basic publishing example. 2019-12-12 13:19:51 +00:00
Roger A. Light
c8789180f3 Fix session expiry with very large expiry intervals. 
Closes #1525. Thanks to Christoph Krey.
 2019-12-12 09:40:37 +00:00
Roger A. Light
8a6f179c83 Fix comment. 2019-12-11 15:15:40 +00:00
Roger A. Light
3f0c202aa5 Reduce heap allocation churn when tokenising topics. 2019-12-11 13:23:59 +00:00
Roger A. Light
9ee6e2725c Start of tests for adding subscriptions. 2019-12-04 11:02:52 +00:00
Roger A. Light
6bfd52af9e Update Docker to 1.6.8. 2019-12-03 14:34:11 +00:00
Roger A. Light
c0443637e8 Merge branch 'master' 
Conflicts:
	ChangeLog.txt
	config.mk
	src/context.c
	src/loop.c
	src/subs.c
	test/broker/01-connect-bad-packet.py
	test/broker/02-subpub-qos1-bad-pubcomp.py
	test/broker/02-subpub-qos1-bad-pubrec.py
	test/broker/02-subpub-qos2-bad-puback-1.py
	test/broker/02-subpub-qos2-bad-puback-2.py
	test/broker/02-subpub-qos2-bad-pubcomp.py
	test/broker/02-subpub-qos2.py
	test/broker/07-will-null-topic.py
 2019-12-03 13:59:05 +00:00
Roger A. Light
70cc79a619 snap: mosquitto_rr needs priming. 2019-12-03 10:35:05 +00:00
Roger A. Light
ab6c7416b7 Update download links. 2019-12-03 10:07:12 +00:00
Roger A. Light
e55f7facce Merge branch 'fixes' 2019-11-28 17:14:53 +00:00
Roger A. Light
b410568299 Bump version, add release post. 2019-11-28 17:08:11 +00:00
Roger A. Light
b96739341d Update changelog for last pull request. 
Closes #1513.
 2019-11-28 16:41:35 +00:00
Roger Light
757e88e503
Merge pull request #1514 from basavesh/fixes 
In sub_client.c, call mosquitto_destroy() in cleanup label.
 2019-11-28 16:37:26 +00:00
Roger A. Light
6dec2b468b Remove redundant expiry checks 
This is all now handled in session_expiry.c, through session expiry interval/time.
 2019-11-28 16:19:57 +00:00
Roger A. Light
a46b45b006 Fix persistent_client_expiration not being used 
Closes #1494. Thanks to Christoph Krey.
 2019-11-28 16:17:41 +00:00
Basavesh Shivakumar
9bebab46ca In sub_client.c, call mosquitto_destroy() 
Fixes: #1513 and frees resources when someone terminates
via SIGTERM or SIGINT.

Signed-off-by: Basavesh Shivakumar <basavesh.shivakumar@gmail.com>
 2019-11-27 17:33:11 -05:00
Roger Light
d92360dd8e Split sub and retain trees. 2019-11-22 14:07:15 +00:00
Roger A. Light
c37251c53d Document mosquitto_connect_srv(). 
Closes #1499. Thanks to Basavesh Shivakumar.
 2019-11-22 11:16:53 +00:00
Roger A. Light
fc238895d1 Merge branch 'basavesh-master' into fixes 2019-11-21 14:22:36 +00:00
Roger A. Light
91961d93c4 Merge branch 'master' of git://github.com/basavesh/mosquitto into basavesh-master 2019-11-21 14:22:19 +00:00
Basavesh Shivakumar
7c34ed2eeb Delete duplicate 'Returns' messages in the comments. 
Signed-off-by: Basavesh Shivakumar <basavesh.shivakumar@gmail.com>
 2019-11-16 21:44:18 -05:00
Roger A. Light
a26157643d Add rr to snap. Add home plug to snap (not autoconnected). 2019-11-14 11:00:26 +00:00
Roger A. Light
3d92dcbbd9 Make documentation for mosquitto_pub -l match reality 
Blank lines are sent as empty messages.

Closes #1474. Thanks to majekw.
 2019-11-07 20:49:59 +00:00
Roger A. Light
1e04b22833 Fix mosquitto_pub -l not sending the final line of stdin 
This would happen if the final line did not end with a new line.

Closes #1473. Thanks to majekw.
 2019-11-07 18:25:56 +00:00
Roger A. Light
d003fed383 MQTT v5 bridges can handle "retain-available" being false. 2019-11-07 13:31:42 +00:00
Roger A. Light
16dc5456bd Enable MQTT v5 in outgoing retain test. 2019-11-07 13:25:46 +00:00